[Server] Stop concurrent writes from corrupting session files - #500
Open
chr-hertel wants to merge 4 commits into
Open
[Server] Stop concurrent writes from corrupting session files#500chr-hertel wants to merge 4 commits into
chr-hertel wants to merge 4 commits into
Conversation
Give each write its own temporary file, collect the leftovers in gc(), and degrade an undecodable payload to an empty session.
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
September 7, 2026 22:18
chr-hertel
added
bug
proc_get_status() reaps the process before PHP 8.3, so the later proc_close() reported -1 and the unit job failed on 8.1 and 8.2.
An empty file is what an interrupted write leaves behind, never a stored payload, and the interface asks for false when nothing was read.
chr-hertel
commented
Sep 7, 2026
chr-hertel
commented
Sep 7, 2026
chr-hertel
commented
Sep 7, 2026
chr-hertel
commented
Sep 7, 2026
Co-authored-by: Christopher Hertel <mail@christopher-hertel.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #498.
FileSessionStore::write()used one temporary filename per session, so concurrent writers published each other's half-written files. Each write now gets its own;gc()collects the leftovers a killed write leaves behind.Session::readData()threwJsonExceptionon an empty or truncated payload, taking down a request whose tool call had already succeeded. It now degrades to an empty session, which is what the existing!is_array($decoded)branch was always meant to do.Note: the corrupt payload is dropped silently —
Sessionhas no logger.