chore: make async-trait optional - #1119
Open
DaleSeo wants to merge 1 commit into
Open
Conversation
DaleSeo
marked this pull request as ready for review
August 3, 2026 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1112.
Motivation and Context
The default
rmcpfeature set does not compile any code that usesasync-trait, but the unconditional dependency still adds the proc-macro crate to every consumer's build graph. Moving the dependency behind the two features that use it keeps the build graph smaller without changing the public API or runtime behavior.This PR makes
async-traitoptional. Consumers that do not enable OAuth or streamable HTTP server sessions will no longer compile an unused proc macro. Theauthandtransport-streamable-http-server-sessionfeatures now enable the dependency explicitly.How Has This Been Tested?
async-traitis absent with--no-default-features --features base64,macros,server.async-traitis present withauthandtransport-streamable-http-server-sessionindependently.Breaking Changes
None. Existing features continue to enable
async-traitwherever it is required.Types of changes
Checklist