fix: prevent memory leak from process event listeners - #329
Merged
omegascorp merged 1 commit intoAug 28, 2026
Conversation
omegascorp
self-requested a review
August 27, 2026 12:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a MaxListenersExceededWarning caused by repeatedly registering
process.onlisteners instartServeracross tests. It uses a module-level variable to ensure they are added only once.Note
Low Risk
Small control-flow change around existing logging handlers; no new behavior on first boot and no auth or data-path impact.
Overview
Fixes listener accumulation when
startServerruns multiple times in the same Node process (e.g. repeated test runs), which triggeredMaxListenersExceededWarning.Global
unhandledRejectionanduncaughtExceptionhandlers are now registered behind a module-levelglobalProcessListenersRegisteredguard so they attach once; laterstartServercalls skip re-registration. Handler behavior is unchanged.Reviewed by Cursor Bugbot for commit 9e6c1dd. Bugbot is set up for automated code reviews on this repo. Configure here.