Skip to content

fix(websocket): finalize file input on end control - #3440

Merged
LauraGPT merged 1 commit into
mainfrom
codex/fix-websocket-file-finalization-3438-20260729
Jul 29, 2026
Merged

fix(websocket): finalize file input on end control#3440
LauraGPT merged 1 commit into
mainfrom
codex/fix-websocket-file-finalization-3438-20260729

Conversation

@LauraGPT

Copy link
Copy Markdown
Collaborator

Summary

  • finalize buffered offline, online, and 2pass audio when file clients send the end control message
  • add an explicit end-of-input acknowledgement so file clients wait for final results instead of fixed sleeps
  • propagate inference, delivery, and invalid-configuration failures to the client while retaining legacy is_speaking: false support
  • clean up failed websocket sessions and document the completion protocol

Validation

  • pytest -q tests/test_websocket_file_finalization.py (28 passed)
  • expanded websocket/server/docs regression selection (237 passed)
  • python -m py_compile for server, client, and regression test
  • black --check tests/test_websocket_file_finalization.py
  • git diff --check

Fixes #3438

Signed-off-by: LauraGPT <lauragpt@users.noreply.github.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@LauraGPT
LauraGPT merged commit 30caaf8 into main Jul 29, 2026
@LauraGPT
LauraGPT deleted the codex/fix-websocket-file-finalization-3438-20260729 branch July 29, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

funasr_wss_server.py 当python funasr_wss_client.py使用--audio_in方式时,没有正确返回asr,且造成客户端卡死

1 participant