fix(train): align DDP no_sync with gradient accumulation - #3472
Merged
LauraGPT merged 1 commit intoAug 5, 2026
Conversation
LauraGPT
approved these changes
Aug 5, 2026
LauraGPT
left a comment
Collaborator
There was a problem hiding this comment.
Verified against current main and with a two-rank CPU/Gloo DDP reproduction.
The old batch_idx % accum_grad condition synchronizes the first microbatch and suppresses synchronization on the optimizer-step microbatch, leaving rank-local accumulated gradients (4.0 vs 7.0 in the reproduction). The proposed (batch_idx + 1) % accum_grad condition keeps early microbatches inside no_sync() and synchronizes the final microbatch, producing identical accumulated gradients on both ranks (5.5 vs 5.5).
Additional checks:
- synthetic merge with current main is clean and changes only this condition
- python -m py_compile funasr/train_utils/trainer_ds.py
- git diff --check
Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of change
Validation
python -m compileall funasr examples testsUser impact
Notes for reviewers