feat(io): unify undecoding behavior and support overlong images list - #1626
Conversation
|
Thanks for the improvement. Before merging, could you please validate the behavior for datasets without media columns?
Could you please:
Also, please add parameter and return type annotations to |
|
Changes since the last review:
A small note: |
|
@Yunnglin I suggest we default batch size to 1000, for two good reasons:
|
Yunnglin
left a comment
There was a problem hiding this comment.
LGTM. Verified the media undecoding changes locally, including the no-op path, Arrow offset overflow regression, and Image/Audio/Video sequence coverage. All targeted tests and CI checks pass.
Summary
undecode_mediainio_utils, with a no-op bypass when nothing to do. It takes an optional batch_size which defaults to env varDATASET_TF_BATCH_SIZEor 1000.parquet_to_listto useundecode_mediafor binary mediaRemoteLoaderto useundecode_mediafor binary mediabatch_size: default1000may fail in extreme cases.Tests