fix(score): prune rouge scoring function and fix en version of rouge - #1633
Merged
Conversation
Yunnglin
approved these changes
Aug 26, 2026
Yunnglin
left a comment
Yunnglin
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Verified the ROUGE argument-order fix, input safeguards, type annotations, and cleanup. The failing unit test is unrelated to this PR (IQuiz dataset cache/download failure).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compute_rouge_score()compute_rouge_score_one_sample()had inverted reference and prediction.zip()ref: list[str]andpred: list[str]defaults to False, the same behavior as before.