fix(resources): verify NLTK mirror archives with pinned digests - #1663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes fallback NLTK resource downloads fail closed unless the downloaded archive matches a pinned SHA-256 digest.
Root Cause
When a required NLTK resource was absent, check_nltk_data downloaded a ZIP from a mutable third-party mirror and extracted it directly. Although download_url already supports checksum verification, the call did not provide sha256. A valid but replaced or corrupted archive could therefore be installed into the NLTK data directory.
Changes
Reproduction
On the unmodified base, monkeypatching download_url to record its keyword arguments during check_nltk_data(averaged_perceptron_tagger_eng) records sha256 as not passed. The downloader then skips the checksum comparison and resource_utils extracts the returned archive.
Validation
Targeted resource tests:
Adjacent NLTK consumer tests:
CI smoke test:
Lint:
All added tests use mocked NLTK and download behavior; no test accesses the network.
Scope
The change is limited to NLTK mirror integrity and its tests. It intentionally reuses the existing checksum-capable download helper and does not include HTTP resume or other download behavior changes.