Cache downloaded files atomically - #9999
Merged
tastelikefeet merged 1 commit intoAug 28, 2026
Merged
Conversation
tastelikefeet
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
download_file()now streams into a temporary file in the cache directory and atomically replaces the final cache path only after the response finishes. Failed downloads remove their temporary file, so a later call cannot mistake truncated bytes for a valid cached artifact.A focused regression test simulates a connection reset and verifies that the cache directory remains empty.
Experiment results
main: an interrupted stream left a final cache file containingb"half"pre-commit run --files swift/utils/hub_utils.py tests/utils/test_hub_utils.pypython3 -m py_compile swift/utils/hub_utils.py tests/utils/test_hub_utils.pygit diff --check