feat(stml): require experimental opt-in#589
Merged
Merged
Conversation
Contributor
Greptile SummaryRequire launch-scoped opt-in for experimental STML note rendering.
Confidence Score: 5/5The pull request appears safe to merge with no concrete blocking or non-blocking defects identified. Experimental STML remains disabled by default, enabled only by launch input, preserved across reloads, rejected before live-comment mutation in normal sessions, and propagated through backward-compatible session parsing with the required daemon compatibility bump. Important Files Changed
Sequence DiagramsequenceDiagram
participant U as User
participant CLI as CLI/config
participant App as AppHost/UI
participant Broker as Session broker
participant Agent as Agent CLI
U->>CLI: Launch review
CLI->>CLI: Resolve --experimental from launch argv
CLI->>App: Bootstrap with launch capability
App->>App: Strip STML unless opted in
App->>Broker: Register experimentalFeatures
Agent->>Broker: Read session context
Broker-->>Agent: stml capability only when enabled
Agent->>App: Submit live comment
App->>App: Reject markup unless STML enabled
Agent->>App: Request reload
App->>App: Preserve original launch capability
Reviews (1): Last reviewed commit: "feat(stml): require experimental opt-in" | Re-trigger Greptile |
benvinegar
force-pushed
the
feat/experimental-stml-opt-in
branch
from
July 23, 2026 20:44
e6a81c1 to
8d52c25
Compare
benvinegar
force-pushed
the
feat/experimental-stml-opt-in
branch
from
July 24, 2026 13:34
8d52c25 to
b19d53a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--experimentalflag and keep STML disabled by defaultstmlthrough opted-in session context, while preventing config or reload escalationTesting
bun run format:checkbun run lintbun run typecheckbun run test(1209 passed, 5 skipped)bun run test:tty-smoke(9 passed)bun run test:integration(56 passed; the atomic-save watch test times out identically on freshorigin/main)This PR description was generated by Pi using OpenAI GPT-5.4