Skip to content

fix(session): support IPv6 loopback broker URLs - #613

Merged
benvinegar merged 1 commit into
mainfrom
fix/ipv6-session-broker-origin
Jul 28, 2026
Merged

fix(session): support IPv6 loopback broker URLs#613
benvinegar merged 1 commit into
mainfrom
fix/ipv6-session-broker-origin

Conversation

@benvinegar

Copy link
Copy Markdown
Member

Summary

  • format literal IPv6 session-broker hosts as bracketed URL authorities
  • cover IPv6 HTTP and WebSocket origin generation
  • add a patch changeset

Verification

  • bun test src/session-broker/brokerConfig.test.ts
  • bun run typecheck
  • bun run lint

This PR description was generated by Pi using GPT-5.2

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hunk-web Building Building Preview Jul 28, 2026 3:07am

Request Review

@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes session-broker URL generation for literal IPv6 hosts.

  • Brackets IPv6 literals when constructing HTTP and WebSocket URL authorities while preserving the raw socket host.
  • Adds regression coverage for IPv6 loopback origins.
  • Adds a patch changeset for hunkdiff.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The changed origin formatting produces valid bracketed IPv6 authorities while retaining the unbracketed host required by socket APIs, and existing authority validation accepts the resulting form.

Important Files Changed

Filename Overview
src/session-broker/brokerConfig.ts Correctly distinguishes socket host syntax from bracketed IPv6 URL-authority syntax.
src/session-broker/brokerConfig.test.ts Adds focused regression coverage for HTTP and WebSocket origins generated from ::1.
.changeset/fix-ipv6-session-broker-origins.md Records the IPv6 loopback fix as a patch release.

Reviews (1): Last reviewed commit: "fix(session): support IPv6 loopback brok..." | Re-trigger Greptile

@benvinegar
benvinegar merged commit 3ba2559 into main Jul 28, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant