refactor(architecture): establish application boundaries - #624
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryEstablishes a dedicated application-composition boundary and consolidates startup/reload bootstrapping.
Confidence Score: 5/5The PR appears safe to merge; no concrete behavioral, build, import, or security regressions were identified. The shared bootstrap preserves the prior launch and reload ordering, moved-module consumers resolve through their new paths, and the architecture boundary is reinforced without altering the underlying VCS or theme implementations. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
Main[src/main.tsx] --> Startup[src/app/startup.ts]
Startup --> Bootstrap[src/app/sessionBootstrap.ts]
Reload[src/ui/AppHost.tsx] --> Bootstrap
Bootstrap --> Config[src/core/config.ts]
Bootstrap --> Extensions[src/extensions]
Bootstrap --> Loaders[src/core/loaders.ts]
Loaders --> VCS[src/core/vcs]
Bootstrap --> UI[src/ui]
Core[src/core] -. prohibited import .-> UI
Reviews (1): Last reviewed commit: "chore(release): add empty changeset" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/app/as the small executable-composition boundary and share session bootstrap work between startup and UI reloadssrc/core/vcs/and move the shared Shiki theme catalog intocoreValidation
bun run typecheckbun run lintbun test ./src ./packages ./scripts ./test/cli ./test/session(1,638 passed, 9 skipped)Notes
passively refreshes direct files after an atomic saveremains failing on a cleanorigin/mainworktree; it is pre-existing and unrelated to this refactor.This PR description was generated by Pi using OpenAI GPT-5