fix(ui): keep the menu bar inside the app's gutter - #693
Conversation
The menu bar was a single full-width box whose horizontal padding was painted with the chrome background, so the two outer columns read as chrome while every row below leaves them as the app background. The result was a top bar that visibly failed to line up with the panes under it. Move the chrome band into an inner box and let the outer row paint the app background, so the bar leaves the same one-column margin the body panes leave. Column positions are unchanged: menu labels still start at column 1, so MenuSpec.left and dropdown anchoring stay correct. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThe PR moves the menu bar’s chrome background into an inner flex row so the outer terminal columns retain the application background.
Confidence Score: 4/5The PR appears safe to merge functionally, with only a non-blocking repository-formatting issue to correct. The menu-bar layout change has targeted PTY coverage and no concrete behavioral regression was established; the accepted concern is limited to changed TypeScript and TSX formatting. Files Needing Attention: src/ui/components/chrome/MenuBar.tsx, test/pty/chrome.test.ts, test/pty/harness.ts Important Files Changed
Prompt To Fix All With AI### Issue 1
src/ui/components/chrome/MenuBar.tsx:24-25
**Keep changed code formatting consistent**
The changed TypeScript and TSX blocks use two-space indentation and double-quoted strings instead of the repository-required four-space indentation and single quotes, creating inconsistent formatting across the menu implementation and its PTY coverage.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "fix(ui): keep the menu bar inside the ap..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| // The outer row paints the app background so the bar keeps the same | ||
| // one-column gutter the body panes have; only the inner band is chrome. |
There was a problem hiding this comment.
The changed TypeScript and TSX blocks use two-space indentation and double-quoted strings instead of the repository-required four-space indentation and single quotes, creating inconsistent formatting across the menu implementation and its PTY coverage.
Context Used: guidelines.mdc Cursor rule (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/ui/components/chrome/MenuBar.tsx
Line: 24-25
Comment:
**Keep changed code formatting consistent**
The changed TypeScript and TSX blocks use two-space indentation and double-quoted strings instead of the repository-required four-space indentation and single quotes, creating inconsistent formatting across the menu implementation and its PTY coverage.
**Context Used:** guidelines.mdc Cursor rule ([source](https://github.com/modem-dev/modem/blob/main/.cursor/rules/guidelines.mdc))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
1 participant
The top menu bar painted its chrome background into the two outer gutter columns, so it didn't line up with the panes below — the app's one-column margin ran down the whole UI except the top row.
MenuBarwas one full-width box withpaddingLeft/paddingRight: 1andbackgroundColor: theme.panelAlt, so the padding cells were chrome. This moves the band into an innerflexGrow: 1box and lets the outer row painttheme.background.Real PTY captures at 90 columns, rendered cell-for-cell from the colors the terminal received. The zooms magnify the edge columns: before, the band runs to the very edge on the menu row; after, the dark gutter is continuous down both sides.
Column positions are unchanged — labels still start at column 1, so
MenuSpec.left,MenuDropdownanchoring, andmenuBarTitleWidthall still hold.Adds a PTY regression test asserting the menu bar's edge cells match the body's, plus a
rowCellBackgroundsharness helper — text snapshots can't see this bug, only the cell background differs. Confirmed the test fails without the fix.typecheck,lint,test/pty/chrome.test.ts, andtest:tty-smokeare clean.bun testhas 5 failures inextensions-integrationandfile-views-integration; they fail identically on the unmodified baseline, so they're pre-existing and unrelated.🤖 Generated with Claude Code