fix(ui): prevent highlight cache identity collisions - #889
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR replaces sampled highlight-cache fingerprints with memoized SHA-256 identities covering complete patch and parsed metadata content.
Confidence Score: 5/5The PR appears safe to merge, with the cache-identity fix covered by a targeted adversarial regression test. The new key hashes all patch and metadata content, separates languages, preserves source-provider identity, and memoizes repeat hashing without exposing a concrete stale-cache, startup, or compatibility failure. Important Files Changed
Reviews (1): Last reviewed commit: "fix(ui): prevent highlight cache identit..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
bun run typecheckbun run test— 1,591 pass, 2 skipbun run test:integration— 132 pass, 1 skipbun run test:tty-smoke— 9 passbun run deps:checkbun run benchmarks/highlight-cache-layers.tsThis PR description was generated by Pi using gpt-5.6-sol