Skip to content

chore(test): upgrade tuistory - #930

Merged
benvinegar merged 2 commits into
mainfrom
chore/upgrade-tuistory
Aug 30, 2026
Merged

chore(test): upgrade tuistory#930
benvinegar merged 2 commits into
mainfrom
chore/upgrade-tuistory

Conversation

@benvinegar

Copy link
Copy Markdown
Member

Summary

  • upgrade Tuistory from 0.0.16 to 0.11.0
  • retain Hunk's proven 60ms PTY settling delay through Tuistory's new idleDelayMs option
  • pick up the zigpty backend and newer process lifecycle, snapshot, and exit-handling fixes

Performance

The representative test/pty/chrome.test.ts suite was effectively unchanged: 11.44s before and 11.52s after. The explicit 60ms delay avoids regressing to Tuistory's newer, safer 200ms default; this upgrade is primarily a dependency and reliability improvement rather than a measured Hunk test speedup.

Validation

  • bun run typecheck
  • bun run lint
  • bun run test:integration — 139 passed, 1 platform-specific test skipped

Tested on Linux. No user-visible UI behavior changed, so no visual evidence is included.

This PR description was generated by Pi using gpt-5.6-sol

@vercel

vercel Bot commented Aug 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
hunk-web Ignored Ignored Preview Aug 30, 2026 9:56pm

Request Review

@socket-security

socket-security Bot commented Aug 30, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedtuistory@​0.0.16 ⏵ 0.11.093 +17100100 +193 -2100

View full report

@greptile-apps

greptile-apps Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR upgrades the Tuistory PTY test dependency to 0.11.0 and preserves the harness’s intended 60ms settling interval.

  • Replaces Tuistory’s previous node-pty dependency path with its newer zigpty/OpenTUI dependency graph.
  • Passes idleDelayMs: 60 through both Hunk and shell terminal launch paths.
  • Updates the Bun lockfile, but omits the corresponding generated Nix lockfile update.

Confidence Score: 4/5

The PR should not merge until the generated Nix dependency lock is updated, otherwise the Nix CI job will fail.

The Tuistory version changed in package.json and bun.lock while nix/bun.lock.nix remains on 0.0.16; the Nix workflow deterministically regenerates that file and rejects the resulting diff.

Files Needing Attention: package.json and nix/bun.lock.nix

Important Files Changed

Filename Overview
package.json Upgrades Tuistory to ^0.11.0 without the required corresponding Nix lockfile regeneration, causing Nix CI to fail.
bun.lock Resolves Tuistory 0.11.0 and its new zigpty/OpenTUI dependency graph consistently with package.json.
test/pty/harness.ts Applies the intended 60ms Tuistory idle delay consistently to both terminal launch paths.
.changeset/fast-tuis-wait.md Adds an empty changeset appropriate for a dependency-only test infrastructure change.
Prompt To Fix All With AI
### Issue 1
package.json:155
**Nix dependency lock remains stale**

When the Nix CI job runs, it regenerates `nix/bun.lock.nix` from the updated Bun lock, but the committed Nix lock still pins Tuistory 0.0.16, causing the job to fail with the lockfile-out-of-date error. Regenerate and commit `nix/bun.lock.nix` with this dependency upgrade.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "chore(test): upgrade tuistory" | Re-trigger Greptile

Comment thread package.json
"react": "^19.2.4",
"simple-git-hooks": "^2.13.1",
"tuistory": "^0.0.16",
"tuistory": "^0.11.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Nix dependency lock remains stale

When the Nix CI job runs, it regenerates nix/bun.lock.nix from the updated Bun lock, but the committed Nix lock still pins Tuistory 0.0.16, causing the job to fail with the lockfile-out-of-date error. Regenerate and commit nix/bun.lock.nix with this dependency upgrade.

Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 155

Comment:
**Nix dependency lock remains stale**

When the Nix CI job runs, it regenerates `nix/bun.lock.nix` from the updated Bun lock, but the committed Nix lock still pins Tuistory 0.0.16, causing the job to fail with the lockfile-out-of-date error. Regenerate and commit `nix/bun.lock.nix` with this dependency upgrade.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Regenerated and committed nix/bun.lock.nix with the pinned bun2nix version in a48d50a. I also confirmed a second generation produces identical output.

Responded by pi using gpt-5.6-sol.

This comment was generated by Pi using gpt-5.6-sol

@benvinegar
benvinegar merged commit 8b0f2b6 into main Aug 30, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant