chore(test): upgrade tuistory - #930
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Greptile SummaryThis PR upgrades the Tuistory PTY test dependency to 0.11.0 and preserves the harness’s intended 60ms settling interval.
Confidence Score: 4/5The PR should not merge until the generated Nix dependency lock is updated, otherwise the Nix CI job will fail. The Tuistory version changed in package.json and bun.lock while nix/bun.lock.nix remains on 0.0.16; the Nix workflow deterministically regenerates that file and rejects the resulting diff. Files Needing Attention: package.json and nix/bun.lock.nix Important Files Changed
Prompt To Fix All With AI### Issue 1
package.json:155
**Nix dependency lock remains stale**
When the Nix CI job runs, it regenerates `nix/bun.lock.nix` from the updated Bun lock, but the committed Nix lock still pins Tuistory 0.0.16, causing the job to fail with the lockfile-out-of-date error. Regenerate and commit `nix/bun.lock.nix` with this dependency upgrade.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "chore(test): upgrade tuistory" | Re-trigger Greptile |
| "react": "^19.2.4", | ||
| "simple-git-hooks": "^2.13.1", | ||
| "tuistory": "^0.0.16", | ||
| "tuistory": "^0.11.0", |
There was a problem hiding this comment.
Nix dependency lock remains stale
When the Nix CI job runs, it regenerates nix/bun.lock.nix from the updated Bun lock, but the committed Nix lock still pins Tuistory 0.0.16, causing the job to fail with the lockfile-out-of-date error. Regenerate and commit nix/bun.lock.nix with this dependency upgrade.
Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 155
Comment:
**Nix dependency lock remains stale**
When the Nix CI job runs, it regenerates `nix/bun.lock.nix` from the updated Bun lock, but the committed Nix lock still pins Tuistory 0.0.16, causing the job to fail with the lockfile-out-of-date error. Regenerate and commit `nix/bun.lock.nix` with this dependency upgrade.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.There was a problem hiding this comment.
Good catch. Regenerated and committed nix/bun.lock.nix with the pinned bun2nix version in a48d50a. I also confirmed a second generation produces identical output.
Responded by pi using gpt-5.6-sol.
This comment was generated by Pi using gpt-5.6-sol
Summary
idleDelayMsoptionPerformance
The representative
test/pty/chrome.test.tssuite was effectively unchanged: 11.44s before and 11.52s after. The explicit 60ms delay avoids regressing to Tuistory's newer, safer 200ms default; this upgrade is primarily a dependency and reliability improvement rather than a measured Hunk test speedup.Validation
bun run typecheckbun run lintbun run test:integration— 139 passed, 1 platform-specific test skippedTested on Linux. No user-visible UI behavior changed, so no visual evidence is included.
This PR description was generated by Pi using gpt-5.6-sol