Fix Python version extraction regex for docker-borgmatic Dockerfile - #75
Merged
Conversation
docker-borgmatic's Dockerfile now sets the Python version via ARG PYTHON_VERSION instead of hardcoding it in the FROM line, so the old regex matched nothing and failed the setup job (exit 1 under bash -e).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setupjob's "Fetch Python version from docker-borgmatic Dockerfile" step is failing on master and on Update dependency borgbackup to v1.4.5 #74 withProcess completed with exit code 1.base-fullbuild/), butdocker-borgmatic's Dockerfile also changed how it declares the Python version — it now usesARG PYTHON_VERSION=3.14+FROM python:${PYTHON_VERSION}-alpine...instead of a literalFROM python:X.Y. The old regex(?<=FROM python:)\d+\.\d+no longer matches anything,grepexits 1, and the step dies underbash -e.ARG PYTHON_VERSION=line instead.Test plan
curl -s https://raw.githubusercontent.com/modem7/docker-borgmatic/master/Dockerfile | grep -oP '(?<=^ARG PYTHON_VERSION=)\d+\.\d+'returns3.14