test: grow the integration scenario set (env_file, runtime interpolation)#44
Merged
Merged
Conversation
…ed by the outer script
Both scenarios wrote a bare $COLOR/$TOKEN meant to be read by the CONTAINER's
own shell, but compose2pod's own ${VAR} interpolation applies uniformly to
every emitted string -- including command: list entries -- so it got
resolved by the OUTER script against ITS OWN environment instead, producing
an empty value before the command ever reached the container. Confirmed by
generating the script locally: the command rendered as "echo \"${COLOR-}\""
rather than the literal "echo \"$COLOR\"". $$ is Compose's own escape for a
literal $, verified via the same local-generation check to render correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Grows the podman integration harness further (from #41, #43) with two more behavioral scenarios, per
planning/changes/2026-07-13.03-grow-integration-scenarios-env.md. No harness,conftest.py,pyproject.toml, or CI config changes -- each scenario reuses the existingrun_podfixture.env_file-- a real host file, resolved againstproject_dir, loaded into the container's actual environment via--env-file.${VAR}interpolation -- a variable set viamonkeypatch.setenvjust beforerun_podproves the${VAR}reference survives compose2pod's generation step as a live shell expansion (never baked into a literal):run_pod's subprocess call inherits the current process environment, so the whole chain -- generation, the outer script's own shell expansion, and podman actually setting the container's env -- gets exercised end to end.Both underlying code paths (
_add_env_flags's path resolution, and theemit.py->keys.py->shell.pyinterpolation chain) were independently traced to source during task review, not assumed -- a prior round in this series shipped a scenario with an unverified file-format assumption that only surfaced in CI, so this round's reviews were deliberately more skeptical.Verification
just test-ciat 100% (363 passed, 8 deselected);just lint-ciandjust check-planningclean. Both scenarios usebusybox:1.36, already cached. Behavioral green is produced by the existingintegrationCI job.