docs(planning): file the two defects deferred from the access-log fix - #163
Merged
Conversation
Both were found while fixing the Litestar access-log body leak (#162) and kept out of it to leave a security fix unencumbered. - log_stream binds sys.stdout at import, so structlog output ignores a stdout the process rebinds before bootstrap, while the root-logger handler follows it. - Litestar.from_config() skips the request_max_body_size default that Litestar.__init__ applies, so every body-reading handler returns 500 unless the caller sets the field themselves.
The from_config/__init__ default divergence is already tracked as litestar-org/litestar#4296; link it and our reproduction instead of asking a future implementer to file a duplicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two proposals, no code. Both defects surfaced while fixing the Litestar access-log body leak (#162) and were deliberately kept out of it.
planning/changes/2026-08-10.02-log-stream-bind-at-bootstrap.md(lightweight) —_MemoryLoggerFactoryConfig.log_streambindssys.stdoutat import time, so structlog output ignores a stdout the process rebinds before bootstrap, while_configure_foreign_loggers' root handler follows it. Reproduced with a plainFreeBootstrapperundercontextlib.redirect_stdout, so it affects every bootstrapper.planning/changes/2026-08-10.03-litestar-request-max-body-size.md(full) —Litestar.from_config()skips the 10 MBrequest_max_body_sizedefault thatLitestar(...)applies, so any handler reading a request body returns 500 unless the caller sets the field on their ownAppConfig. Design: fill it in_apply_configonly when it isEmpty, pinned by a guard test against Litestar's own signature default, plus an upstream issue.just check-planningandjust lint-cipass.🤖 Generated with Claude Code