fix: open per-request child container for modern-di 3.x mandatory-open - #5
Merged
Conversation
modern-di 3.0 makes container opening mandatory (resolving from, or building a child of, an unopened container raises ContainerClosedError).
_enter_request builds the REQUEST child in the before_request hook and a separate teardown_appcontext hook closes it later, so there is no enclosing `with` block to open the child implicitly. Under modern-di 3.0's mandatory-open lifecycle this left the child unopened, and every resolve against it raised ContainerClosedError. Open it right after building.
setup_di still does not open the root container it's given — Flask has no application-startup hook to attach that to, and the maintainer ruled root lifecycle (open and close alike) stays the caller's responsibility, symmetric with the existing caller-owned teardown contract. README and the architecture doc now say so explicitly; the test fixture and the two inline Container(...) constructions in test_middleware.py open the root container via `with` so the suite exercises the real path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
modern-di-flaskonto modern-di 3.x. Part of the 12-package wave; unlike most sibling adapters, this one had a genuine adapter bug under the new mandatory-open lifecycle (approved by the maintainer, TDD: existing suite reproduces).modern-dito>=3,<4(drops 2.x support)._enter_requestbuilds the per-requestREQUESTchild inbefore_requestand a separateteardown_appcontexthook closes it later — two hooks, no enclosingwithblock. Under modern-di 3.0 the child was never opened, so every resolve raisedContainerClosedError. Fixed by callingchild.open()right after building it.setup_distill does not open the root container — Flask has no application-startup hook to attach that to, and this stays symmetric with the pre-existing caller-owned-teardown contract. The test fixture and README now open the root container explicitly (with Container(...) as container: .../container.open()) before callingsetup_di, so the suite exercises the real path.Release notes in
planning/releases/3.0.0.md; change bundle inplanning/changes/2026-07-20.01-open-request-child-container.md;architecture/dependency-injection.mdupdated to match.🤖 Generated with Claude Code