test: improve tests stability#3136
Merged
Merged
Conversation
|
bashmish
force-pushed
the
test/improve-reload-test-stability
branch
3 times, most recently
from
July 22, 2026 10:22
ef9173e to
d832183
Compare
bashmish
force-pushed
the
test/improve-reload-test-stability
branch
2 times, most recently
from
July 22, 2026 12:40
5bd89be to
01b2734
Compare
bashmish
force-pushed
the
test/improve-reload-test-stability
branch
from
July 22, 2026 14:41
01b2734 to
0f5cfec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Improved test stability, mainly in Windows, but also in Node.
Unfortunately not all tests were fixed and I still observe random failures on Windows, much less on Node.
I see that many of our tests depend on magical timers. I figured that on Windows the timer resolution (or "tick") is 15.625 ms which is really long as compared to Unix systems, where it's 1 second IIUC (didn't thoroughly checked this for all possible OS, but in our case I think it's reflecting current situation quite well). Therefore what we often consider to be a Windows issue is not necessarily a Windows issue, just the possibility of it being flaky on Windows is many times higher.
Some tests depends on the tick to be shorter than 15ms, then it's a Windows-only flaky test, I fixed a few of those which failed very often.
Overall it's hard to say how many tests are still flaky, I was able to see 3 random places in tests which failed today on Windows after my fixes, at some point I had to proceed to other tasks, can't continue on this, especially because I don't have a local Windows machine for testing.