Skip to content

Environment Variables won't save #2164

Description

@DannyJacoby

Please confirm the following.

  • I checked the existing issues for duplicate problems
  • I have tried resolving the issue using the support portal
  • I have ensured my Modrinth App installation is up to date

What version of the Modrinth App are you using?

7.1

What operating systems are you seeing the problem on?

Windows, MacOS

Describe the bug

In this current build, I can't modify/add in custom environment variables. I can add them in the desktop application's window, however they aren't saved.
I've gone into the settings.json file to add them, however I can't seem to get the format correct as I keep getting this error:
theseus::state::settings: Failed to load settings file: Serialization error (JSON): invalid type: string "-XX:+UnlockExperimentalVMOptions", expected a tuple of size 2 at line 12 column 58.

Steps to reproduce

The easiest method to reproduce this issue is to go into the application, go to the settings (global settings or individual modpack, it can be replicated in either), and then enter any java specific settings (like "-XX:+UnlockExperimentalVMOptions").
These settings will not be saved, and if you were to try and input these settings specifically into the settings.json file, the launcher will have to recreate the settings file and will log the above error.

Expected behavior

That any custom environment variables would be saved.

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    appRelates to Modrinth App

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions