feat(theseus): Add configurable instance / default symlinks#5898
Closed
R2bEEaton wants to merge 4 commits into
Closed
feat(theseus): Add configurable instance / default symlinks#5898R2bEEaton wants to merge 4 commits into
R2bEEaton wants to merge 4 commits into
Conversation
Member
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
Member
|
Hi there, thanks for creating a PR - Unfortunately we can’t accept this PR into the Modrinth App as it is too large in scope and requires more planning to align with our overarching design goals. We are happy to accept contributions from outside collaborators, but for large scope changes like these it’s best to discuss with us on Discord to ensure it’s something that would fit well into the app. For the best chances of getting your PRs accepted, we recommend to tackling smaller scoped QOL features and bugs that are more easily reviewable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feature request #5407, and bugs related to symlinks in #4280 and #915. These changes were largely completed by ChatGPT's Codex 5.4 and were used and tested manually by me.
Summary
Adds configurable per-instance file links and default file links for new instances, with safer symlink handling across export and deletion paths.
This branch:
File linkstab to instance settingsFile linkssupport in Default Instance Settings for newly created instancesUser-Facing Changes
File linkstab where users can:screenshotsoroptions.txtFolderorFileFile linksat the bottom of the page, so new instances can inherit the same links automatically.Backend / Data Model
file_linkspersistence for profilesfile_linkspersistence for global default instance settingsSymlink Safety
This branch also improves behavior around symlinks/junctions:
This directly fixes the mrpack export issue from
#915and hardens app-side recursive deletion behavior related to#4280.