This repository was archived by the owner on Oct 19, 2024. It is now read-only.
openapi: Change schema type for loaders and game_versions to string #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema
loadersandgame_versionsin the endpoint/project/{id|slug}/versionare currently defined as:this is wrong.
It would mean that my request to list project versions would look like this:
https://api.modrinth.com/v2/project/Ojp3IEa8/version?loaders=paper&loaders=spigot&game_versions=1.20.1&game_versions=1.20.2This does not work and returns this response:
{ "error": "invalid_input", "description": "Error while validating input: Query deserialize error: duplicate field `loaders`" }This PR changes the schema type for
loadersandgame_versionsto string.It is actually a string, written like an array in json.
New
And the request will look like this:
https://api.modrinth.com/v2/project/smithing-table-fix/version?loaders=["paper","spigot"]&game_versions=["1.20.1","1.20.2"]Related to #138