This repository was archived by the owner on Oct 19, 2024. It is now read-only.
openapi: Change schema for user ids to string #140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema for the user IDs in
/usersis currently defined as:this is wrong.
It would mean that my request to fetch multiple users would look like this:
https://api.modrinth.com/v2/users?ids=vNcGR3Fd&ids=EBqEP7KkThis does not work and returns this response:
{ "error": "invalid_input", "description": "Error while validating input: Query deserialize error: duplicate field `ids`" }This PR changes the schema for the user ids to string.
It is actually a string, written like an array in json.
New
And the request will look like this:
https://api.modrinth.com/v2/users?ids=["vNcGR3Fd", "EBqEP7Kk"]Related to: