Skip to content

[stdlib] Support __add__ and __mul__ operators for List#2590

Closed
bgreni wants to merge 1 commit intomodular:nightlyfrom
bgreni:list_add_mul
Closed

[stdlib] Support __add__ and __mul__ operators for List#2590
bgreni wants to merge 1 commit intomodular:nightlyfrom
bgreni:list_add_mul

Conversation

@bgreni
Copy link
Copy Markdown
Contributor

@bgreni bgreni commented May 8, 2024

Fixes #2589

@bgreni bgreni requested a review from a team May 8, 2024 18:58
Comment thread stdlib/src/collections/list.mojo
Comment thread stdlib/src/collections/list.mojo
Comment thread stdlib/src/collections/list.mojo Outdated
Signed-off-by: Brian Grenier <grenierb96@gmail.com>
Copy link
Copy Markdown
Member

@JoeLoser JoeLoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@JoeLoser JoeLoser self-assigned this May 10, 2024
@JoeLoser JoeLoser added the imported-internally Signals that a given pull request has been imported internally. label May 10, 2024
@modularbot
Copy link
Copy Markdown
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added the merged-internally Indicates that this pull request has been merged internally label May 10, 2024
JoeLoser pushed a commit that referenced this pull request May 11, 2024
…st` (#39734)

[External] [stdlib] Support `__add__` and `__mul__` operators for `List`

Fixes #2589

Co-authored-by: bgreni <42788181+bgreni@users.noreply.github.com>
Closes #2590
MODULAR_ORIG_COMMIT_REV_ID: e08d28e0b92394a419ff4d5b231b969ec74635e1
@JoeLoser JoeLoser added the merged-externally Merged externally in public mojo repo label May 11, 2024
@JoeLoser
Copy link
Copy Markdown
Member

Landed in today's nightly: #2615. Thanks for the contribution!

@JoeLoser JoeLoser closed this May 11, 2024
lsh pushed a commit to lsh/mojo that referenced this pull request May 17, 2024
…st` (#39734)

[External] [stdlib] Support `__add__` and `__mul__` operators for `List`

Fixes modular#2589

Co-authored-by: bgreni <42788181+bgreni@users.noreply.github.com>
Closes modular#2590
MODULAR_ORIG_COMMIT_REV_ID: e08d28e0b92394a419ff4d5b231b969ec74635e1

Signed-off-by: Lukas Hermann <lukashermann28@gmail.com>
modularbot pushed a commit that referenced this pull request Jun 7, 2024
…st` (#39734)

[External] [stdlib] Support `__add__` and `__mul__` operators for `List`

Fixes #2589

Co-authored-by: bgreni <42788181+bgreni@users.noreply.github.com>
Closes #2590
MODULAR_ORIG_COMMIT_REV_ID: e08d28e0b92394a419ff4d5b231b969ec74635e1
modularbot pushed a commit that referenced this pull request Apr 24, 2025
…st` (#39734)

[External] [stdlib] Support `__add__` and `__mul__` operators for `List`

Fixes #2589

Co-authored-by: bgreni <42788181+bgreni@users.noreply.github.com>
Closes #2590
BUFFER_ORIG_REV_ID: e08d28e0b92394a419ff4d5b231b969ec74635e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

imported-internally Signals that a given pull request has been imported internally. merged-externally Merged externally in public mojo repo merged-internally Indicates that this pull request has been merged internally

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants