Allow CC dependencies to propagate through mojo_library targets - #105
Merged
Ahajha merged 2 commits intoAug 4, 2026
Merged
Conversation
Right now these can only be declared through mojo_binary/mojo_test targets, which are generally leaves. This allows us to use them in non-leaf targets.
Ahajha
force-pushed
the
trotta/allow-cc-dependencies-to-propagate-through-mojo_library-targets
branch
from
August 4, 2026 03:17
a504d1b to
4fa63b9
Compare
Ahajha
marked this pull request as ready for review
August 4, 2026 23:22
Ahajha
deleted the
trotta/allow-cc-dependencies-to-propagate-through-mojo_library-targets
branch
August 4, 2026 23:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now these can only be declared through mojo_binary/mojo_test targets, which are generally leaves. This allows us to use them in non-leaf targets.