Skip to content

fix: preserve SSR entry during cleanup - #1035

Merged
gioboa merged 2 commits into
mainfrom
fix/ssr-emit
Aug 6, 2026
Merged

fix: preserve SSR entry during cleanup#1035
gioboa merged 2 commits into
mainfrom
fix/ssr-emit

Conversation

@gioboa

@gioboa gioboa commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Ensures Vite 5–7 emits remoteEntry.ssr.js even when ssrEmitAssets is disabled, without enabling unrelated SSR assets.

@pkg-pr-new

pkg-pr-new Bot commented Aug 6, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@module-federation/vite@1035

commit: 1e46428

@gioboa gioboa left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmchoi77 is this solving your concern?

@gioboa gioboa left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests With Different Frameworks

Image

@dmchoi77

dmchoi77 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@gioboa Yes, this perfectly addresses my concern. Thanks for the quick fix!🚀

@gioboa
gioboa merged commit b833691 into main Aug 6, 2026
22 checks passed
@gioboa
gioboa deleted the fix/ssr-emit branch August 6, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants