chore(mgr): удалить orphan Ext assets (Phase 0 #521) - #530
Merged
Conversation
Delete unused category.tree.js and utilities/import/panel.js; utilities Import tab already uses Vue. OrphanExtAssetsTest prevents re-introducing dead loads.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Phase 0 epic #521: удалены мёртвые ExtJS-ассеты и добавлен smoke-gate против повторного подключения.
product/category.tree.js— нигде не грузился (Categories на Vue)utilities/import/panel.js— вкладка Import уже монтирует Vue (ms3:mountVueImport)utilities.class.phpбольше не вызываетaddJavascript(...import/panel.js)OrphanExtAssetsTest.php— файлы удалены + 0 ссылок в controllers/mgr assetsТип изменений
Связанные Issues
Closes #522
Refs #521
Как это было протестировано?
Локальный CI-гейт (без полной установки MODX/MySQL), PHP lint + smoke:
OrphanExtAssetsTestв smoke suite)Конфигурация тестирования:
fix/issue-522-orphan-ext-cleanupЧеклист
Дополнительные заметки