fix(mgr): declare ms3 via addVueConfig on help page - #554
Merged
Conversation
Help assigned ms3.config without var ms3, which throws ReferenceError before the Vue module mounts. Reuse the same helper as other Vue mgr pages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Страница справки менеджера писала
ms3.config = …без объявленияms3. В консолиReferenceError: ms3 is not defined, Vue не видел конфиг (логотип изms3.config.defaultThumb).Теперь справка вызывает
addVueConfig()до Vue-модуля, как orders/customers/settings:var ms3 = { config }плюс токен менеджера.Тип изменений
Связанные Issues
Closes #553
Как это было протестировано?
Красный → зелёный:
php tests/HelpVueEntryTest.phpсначала падал на отсутствииaddVueConfig, после правкиOK HelpVueEntryTest(exit 0).Vue/ESLint не гонял: фронт не менялся. PHPStan не гонял: новых типов нет.
composer test:smoke)Конфигурация тестирования:
Скриншоты (если применимо)
—
Чеклист
composer stan/ CI jobPHPStan)npm run lint:ciдля Vue)Дополнительные заметки
Ext-контроллеры товара/категории с
ms3.config =не трогал: там Ext/MODx.load. Ревью code-reviewer и thermo-nuclear: блокеров нет.