fix(vue): reuse ms3_menu_remove for product link confirm header - #559
Merged
Conversation
The title key ms3_menu_remove_title does not exist. The confirm body already uses manager lexicon; the same Remove string is enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Заголовок confirm удаления связи показывал ключ
ms3_menu_remove_title. Такого ключа в лексиконах нет. Текст вопроса уже переведён черезms3_menu_remove_confirm.Header берёт существующий
ms3_menu_remove(«Удалить» / «Remove») — тот же ключ, что toast и aria-label. Новых строк в lexicon нет.Тип изменений
Связанные Issues
Closes #556
Как это было протестировано?
Красный → зелёный:
ProductLinksVueTabTestпадал наms3_menu_remove_title, после замены exit 0.composer test:smoke, ESLint на изменённом Vue)Конфигурация тестирования:
Скриншоты (если применимо)
—
Чеклист
composer stan/ CI jobPHPStan)npx eslintнаProductLinksTab.vue)Дополнительные заметки
Новый ключ
ms3_menu_remove_titleне добавлял: вmanager.inc.phpуже естьms3_menu_remove. Ревью code-reviewer и thermo-nuclear: блокеров нет.