Skip to content

Fix rendering of user-entered values in editable listbox-multiple TVs#16640

Merged
opengeek merged 2 commits intomodxcms:2.xfrom
smg6511:2.x-alternate-to-pr-16241
Nov 6, 2024
Merged

Fix rendering of user-entered values in editable listbox-multiple TVs#16640
opengeek merged 2 commits intomodxcms:2.xfrom
smg6511:2.x-alternate-to-pr-16241

Conversation

@smg6511
Copy link
Copy Markdown
Collaborator

@smg6511 smg6511 commented Nov 3, 2024

What does it do?

Back ports fixes already made and merged into 3.x. See the referenced PRs below for more info.

Related issue(s)/PR(s)

Alternate to PR #16241; includes back ports of #16242 and #16561

Primary back port changes (which removes the preservation of selection order)
Adds back in preservation of selection order via a new TV input option
@opengeek
Copy link
Copy Markdown
Member

opengeek commented Nov 4, 2024

@smg6511 — I'm assuming that #16424 is not the PR you meant to reference?

@opengeek opengeek requested a review from theboxer November 4, 2024 18:35
@smg6511
Copy link
Copy Markdown
Collaborator Author

smg6511 commented Nov 4, 2024

@smg6511 — I'm assuming that #16424 is not the PR you meant to reference?

Oops, yes - it's supposed to be #16242

@rthrash rthrash added this to the v2.8.8 milestone Nov 4, 2024
@opengeek opengeek changed the title 2.x-Fix rendering of user-entered values in editable listbox-multiple TVs Fix rendering of user-entered values in editable listbox-multiple TVs Nov 4, 2024
@opengeek opengeek modified the milestones: v2.8.8, v2.9.0 Nov 5, 2024
Copy link
Copy Markdown
Member

@theboxer theboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@opengeek opengeek merged commit c2c62d1 into modxcms:2.x Nov 6, 2024
@opengeek opengeek modified the milestones: v2.9.0, v2.8.8 Nov 21, 2024
@jenswittmann
Copy link
Copy Markdown
Contributor

In my MODX 2.8.8 installation, I need to update the TV. Then the preserveSelectionOrder setting is added to the input_properties array in the database and the values are sorted as stored in the database. Without resaving after core update (missing entry in input_properties array) it will be sorted randomly. Can anyone else confirm this issue?

@modxcommunity
Copy link
Copy Markdown

This pull request has been mentioned on MODX Community. There might be relevant details there:

https://community.modx.com/t/after-upgrading-to-3-x-log-filled-with-listbox-errors/8987/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants