fix(release): use correct secret names for macOS notarization#23
Merged
Conversation
The "Configure macOS signing" step checked for APPLE_CERTIFICATE / APPLE_CERTIFICATE_PASSWORD secrets, but the repo has the certificate configured under different names (BUILD_CERTIFICATE_BASE64, P12_PASSWORD). The check always failed, so the build fell back to ad-hoc mode — and the "Build universal app" step's env block then passed empty-string cert vars to Tauri's bundler, which still attempted `security import` on them and failed with "SecKeychainItemImport: ... not valid / failed to import keychain certificate". Point detection at the secrets that actually exist, and stop redeclaring the cert env vars on the build step (the signing step already exports exactly the right ones to $GITHUB_ENV — leaving them unset in ad-hoc mode is what makes the bundler skip cert import entirely).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/release.ymlchecked forAPPLE_CERTIFICATE/APPLE_CERTIFICATE_PASSWORDrepo secrets, but the certificate is actually configured under different secret names:BUILD_CERTIFICATE_BASE64andP12_PASSWORD. The check always evaluated false, so the build silently fell back toSIGNING_MODE=adhoc.|| ''fallback, which setAPPLE_CERTIFICATE/APPLE_CERTIFICATE_PASSWORDto empty strings (present-but-empty) rather than leaving them unset. Tauri's bundler treats a present env var — even an empty one — as "a certificate is configured" and attemptssecurity importon it, producing:Ghost.dmg— onlyGhost_Setup.exe.Fix
BUILD_CERTIFICATE_BASE64→APPLE_CERTIFICATE,P12_PASSWORD→APPLE_CERTIFICATE_PASSWORD), flipping detection toSIGNING_MODE=fullso the realAPPLE_SIGNING_IDENTITY("Developer ID Application: ...") is used and the app gets signed + notarized.env:block on "Build universal app" — the signing step already exports exactly the right vars to$GITHUB_ENV; leaving cert vars unset (not empty-string) in ad-hoc mode is what makes the bundler skipsecurity importentirely.RELEASING.mdto document the actual secret names in use.Test plan
v1.0.6) to triggerrelease.ymlbuild-maclogs "Apple Developer ID detected → signing + notarizing" /SIGNING_MODE=fullSecKeychainItemImporterrorGhost.dmgandGhost_Setup.exeassets, and the macOS download link on ghost.muharafiq.com resolves correctly