Harden CI/release workflows and make Ghost roadmap realistic#35
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea716bd416
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| push: | ||
| tags: | ||
| - "v*" | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Require a tag for manual releases
When this workflow is run via the newly added workflow_dispatch trigger from the default branch, both softprops/action-gh-release steps run without a tag ref or explicit tag_name, so the release upload is not tied to the intended v* tag and the manual release path fails or targets the branch name. The action's README recommends gating the release step with if: github.ref_type == 'tag' unless a tag_name is supplied, so add a tag input/checkout or restrict the manual trigger to tag refs before uploading assets.
Useful? React with 👍 / 👎.
|
|
||
| - name: Run clippy | ||
| run: cargo clippy --manifest-path src-tauri/Cargo.toml -- -A warnings | ||
| run: cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets -- -D warnings |
There was a problem hiding this comment.
Don't deny warnings while test targets still warn
With this new command, cargo clippy now lints test targets and promotes warnings to errors. The current test target already has rustc warnings in src-tauri/tests/e2e.rs (unused std::thread, Duration, condition, and base), which the old command skipped or allowed, so both macOS and Windows clippy jobs go red before product code is checked. Clean up or allow those warnings before switching to --all-targets -- -D warnings.
Useful? React with 👍 / 👎.
Summary
This PR separates practical build stability work from product positioning cleanup.
CI / release changes
workflow_dispatchto release so packaging can be manually tested without pushing a tag.Ghost.dmgwith explicit failure output if no DMG is produced.Product/docs changes
docs/PRODUCT_ROADMAP.mdwith a realistic path toward a strong product:Notes
I could not verify the exact failing job log from inside this pass because the run ID/log output was not provided. These changes target the likely failure class: mixing normal CI with native installer packaging and making release jobs harder to debug than necessary.
Test plan
Rust CIruns on macOS + Windows.workflow_dispatch.Ghost.dmg.Ghost_Setup.exe.