ci: activate cloud workflow and scope rust.yml away from cloud/ - #393
Merged
Conversation
Moves cloud/ci/cloud.yml into .github/workflows so GitHub actually runs it (files outside .github/workflows are never picked up). Removes cloud/ci/README.md, which documented exactly this problem and is now solved. Also stops rust.yml running its 3-OS Rust matrix on cloud-only PRs — previously every cloud/ PR showed ~22 green checks without compiling, typechecking, or testing a single line of the changed code.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
3 tasks
mohabbis
added a commit
that referenced
this pull request
Aug 3, 2026
Admin merge: this PR only touches cloud/docs/*.md, which rust.yml intentionally skips (path-scoped away from cloud/-only changes per #393). The required status checks list (Check/Test/Clippy/Rustfmt/etc.) is Rust-CI-specific and was never updated to account for that scoping, so a cloud-docs-only PR can never satisfy it through normal triggering. cloud CI and Security Scanning both ran and passed.
mohabbis
added a commit
that referenced
this pull request
Aug 4, 2026
…ecks (#398) Admin merge: this PR only touches cloud/apps/web (a test file), which rust.yml skips (path-scoped away from cloud/-only changes per #393), so the required Rust-CI status checks never trigger. cloud CI's build job (which runs typecheck/test/build) is green, along with Security Scanning. This is the hotfix for the typecheck breakage #397 introduced on master.
mohabbis
added a commit
that referenced
this pull request
Aug 4, 2026
…on (#400) Admin merge: this PR only touches cloud/, which rust.yml skips (path-scoped away from cloud/-only changes per #393), so the required Rust-CI status checks never trigger. Confirmed directly (not via a deferred wakeup this time): cloud CI's build job shows pass (2m9s), along with CodeQL, Dependency Audit, and Secret Scanning.
mohabbis
added a commit
that referenced
this pull request
Aug 4, 2026
…401) Admin merge: this PR only touches cloud/, which rust.yml skips (path-scoped away from cloud/-only changes per #393), so the required Rust-CI status checks never trigger. Confirmed directly (synchronous polling, not a deferred wakeup): all cloud CI checks show pass — build (2m15s), CodeQL Analysis (2m21s), Dependency Audit (5m12s), Secret Scanning (7s).
mohabbis
added a commit
that referenced
this pull request
Aug 4, 2026
) Admin merge: this PR only touches cloud/, which rust.yml skips (path-scoped away from cloud/-only changes per #393), so the required Rust-CI status checks never trigger. Confirmed directly (synchronous polling): all cloud CI checks show pass — build (2m16s), CodeQL Analysis (2m4s), Dependency Audit (5m21s), Secret Scanning (10s).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloud/ci/cloud.ymlinto.github/workflows/cloud.yml— GitHub only runs workflows from that directory, so the cloud CI (typecheck/test/build, real Postgres+Redis service containers) has never actually run.paths-ignoreforcloud/**,docs/**,public/**,**/*.md, and.github/workflows/cloud.ymltorust.yml'spush/pull_requesttriggers, so the 3-OS Rust matrix stops running (and passing) on PRs that touch none of the Rust/Tauri code.cloud/ci/README.md, which documented this exact gap and is now resolved.Depends on #392 (gitleaks allowlist) landing first so this workflow's env vars don't trip the secret scanner once active.
Test plan
cloud.ymlworkflow triggers and passes on this PR (it changescloud/**)rust.ymldoes NOT run on this PR (path-ignored)