docs: establish Core Reset governance - #579
Conversation
📝 WalkthroughWalkthroughThe PR adds Core Reset governance documentation, a removal manifest, a validation scorecard, contributor templates, roadmap rules, and unit tests covering consistency across these artifacts. ChangesCore Reset governance
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
tests/unit/core-reset-governance.test.ts (1)
69-79: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winCover the temporary Core Reset work-item form.
This test does not read
.github/ISSUE_TEMPLATE/core_reset_work_item.yml, so that required contributor entry point can regress while the governance suite remains green. Add assertions for the form’s required reset fields, or add a dedicated test for it.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/unit/core-reset-governance.test.ts` around lines 69 - 79, Add coverage for .github/ISSUE_TEMPLATE/core_reset_work_item.yml in the governance tests, either within routes contributors through the reset contract or a dedicated test. Read the form and assert that its required Core Reset work-item fields are present, using the field labels or symbols defined by the form, while preserving the existing issue-config and pull-request-template assertions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/core-reset/removal-manifest.yml`:
- Around line 93-99: Update the non-code-and-other-language-ingest entry in
removal-manifest.yml so every value under sources is a resolvable glob or
concrete file path; replace the descriptive extraction-path label with the
relevant paths, or move that description into a notes field while preserving the
manifest’s intended scope.
In `@tests/unit/core-reset-governance.test.ts`:
- Line 25: Broaden the roadmap assertion in the governance test so it rejects
any versioned or feature-style roadmap headings, rather than only the literal
“## v0.26” heading. Update the expectation around roadmap to use a pattern or
equivalent assertion covering all such heading formats while preserving the
existing failure behavior for obsolete roadmap content.
- Around line 56-64: Update the manifest validation in the item loop to reject
empty or whitespace-only values: trim each item.id before uniqueness validation,
and trim item.exit_gate plus conditional item.remove_when before checking they
are non-empty. Preserve the existing disposition and status validation, and
ensure uniqueness is evaluated on the trimmed IDs.
---
Nitpick comments:
In `@tests/unit/core-reset-governance.test.ts`:
- Around line 69-79: Add coverage for
.github/ISSUE_TEMPLATE/core_reset_work_item.yml in the governance tests, either
within routes contributors through the reset contract or a dedicated test. Read
the form and assert that its required Core Reset work-item fields are present,
using the field labels or symbols defined by the form, while preserving the
existing issue-config and pull-request-template assertions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 5d4040f3-8dba-441c-8101-bfeb19287832
📒 Files selected for processing (11)
.github/ISSUE_TEMPLATE/config.yml.github/ISSUE_TEMPLATE/core_reset_work_item.yml.github/pull_request_template.mdCONTRIBUTING.mddocs/core-reset/removal-manifest.ymldocs/core-reset/scorecard.mddocs/designs/2026-07-19-core-reset.mddocs/roadmap.mdtests/unit/core-reset-governance.test.tstests/unit/launch-checklist-doc.test.tstests/unit/roadmap-docs.test.ts
💤 Files with no reviewable changes (2)
- tests/unit/roadmap-docs.test.ts
- tests/unit/launch-checklist-doc.test.ts
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
Establish and record the accepted Madar Core Reset governance before any implementation begins.
Why
Madar's current problem is architectural accumulation: new extraction, retrieval, recovery, proof, and integration paths have been added without consistently retiring their predecessors. The reset must begin with an accepted product contract, dependency order, deletion manifest, and stop gates so it cannot become another compatibility layer.
This PR changes governance and documentation only. It starts no reset implementation.
Testing
npm run test:run -- tests/unit/core-reset-governance.test.ts tests/unit/launch-checklist-doc.test.ts tests/unit/install.test.ts— 79/79 passednpm run typechecknpm run buildgit diff --checkyamlpackagee70f6dd(Ubuntu, macOS, and Windows on Node 20 and 22). Local full-suite attempts hit machine-resource timeouts in unrelated benchmark subprocess tests; focused tests pass.Core Reset contract
tests/unit/roadmap-docs.test.ts; obsolete roadmap content replacedReset scope checks
Checklist
Related issues
madar --helpomits the supportedgenerate --spioption #571, and P0: Simplify retrieval to one bounded phase-complete evidence pass #574 is documented and remains dependency-gatedSummary by CodeRabbit