Skip to content

LeanyLabs/storybook 8#403

Merged
hadasfa merged 63 commits into
mondaycom:update/hadas/storybook-3from
LeanyLabs:leanyLabs/storybook-8
Dec 26, 2021
Merged

LeanyLabs/storybook 8#403
hadasfa merged 63 commits into
mondaycom:update/hadas/storybook-3from
LeanyLabs:leanyLabs/storybook-8

Conversation

@LastExileUA

@LastExileUA LastExileUA commented Dec 23, 2021

Copy link
Copy Markdown
Contributor

docs: create new storybooks for Wizard, Breadcrumbs, Skeleton
tests: change style and expand tests for Wizard, Breadcrumbs, Skeleton
fix: broken links inside stories

LastExileUA and others added 30 commits November 11, 2021 15:27
@LastExileUA @Kandio16
Leany labs/storybook 1 (#1)
7af0d0f 
* story: avatar-init

* stories: chips

* stories/delete-old-stories

* stories/add-label

* stories/toggle-init

* stories/add-ArgsTable

* stories/toggle-init

* stories/add-checkbox

* stories/add-radioButton

* stories/fix-btn-group

* stories/add-src

* stories/fix

* stories/add-search-bar-ui

* stories/search-person-column

* stories/fix

* stories/fix

* stories/fix

* chip/test/init

* test/add-chips-tests

* clean up

* stories/add-icons

* stories/add-components

* stories/fix-icons-name

* stories/small-refactoring

* stories/little-fix

* stories/fix

* test/add-tests-plop

* change styling

* remove unused files

* add spaces

Co-authored-by: Kandio16 <kandio1604@gmail.com>
@LastExileUA
Leany labs/storybook 1 (#2)
561b876 
docs: create new storybooks for Avatar, Chip, Toggle
tests: change style and expend tests for Avatar, Chip, Toggle, Button
@LastExileUA
Merge branch 'mondaycom:update/hadas/storybook-3' into update/hadas/s…
48dc2a5 
…torybook-3
@LastExileUA
remove obsolete snapshot
dc7806a
@LastExileUA
revert Button test
8780901
@LastExileUA
remove spaces
ff97868
@LastExileUA
chips: style tests
333459a
@LastExileUA
Merge branch 'mondaycom:update/hadas/storybook-3' into update/hadas/s…
1661111 
…torybook-3
@LastExileUA
Merge branch 'mondaycom:update/hadas/storybook-3' into update/hadas/s…
850985c 
…torybook-3
@LastExileUA
Merge branch 'mondaycom:update/hadas/storybook-3' into update/hadas/s…
b1e5704 
…torybook-3
@LastExileUA
Merge branch 'mondaycom:update/hadas/storybook-3' into update/hadas/s…
d82d019 
…torybook-3
@LastExileUA @Kandio16
LeanyLabs/storybook 2 (#3)
117e1ec 
* story: avatar-init

* stories: chips

* stories/delete-old-stories

* stories/add-label

* stories/toggle-init

* stories/add-ArgsTable

* stories/toggle-init

* stories/add-checkbox

* stories/add-radioButton

* stories/fix-btn-group

* stories/add-src

* stories/fix

* stories/add-search-bar-ui

* stories/search-person-column

* stories/fix

* stories/fix

* stories/fix

* chip/test/init

* test/add-chips-tests

* clean up

* stories/add-icons

* stories/add-components

* stories/fix-icons-name

* stories/small-refactoring

* stories/little-fix

* stories/fix

* test/add-tests-plop

* stories/add-link

* stories/label-init

* stories/add-radio-button

* stories/add-RC

* stories/add-checkbox

* stories/fix-comments

* stories/add

* stories/fix

* stories/merge

* stories/some-fix

* tests/add-tests

* stories/add-link

* stories/fix

* stories/add-size

* fix: small changes in checkbox stories

* polishig

* renamed file according to styles

* polishing

* polishing

Co-authored-by: Kandio16 <kandio1604@gmail.com>
@LastExileUA
Merge branch 'mondaycom:update/hadas/storybook-3' into update/hadas/s…
caac24f 
…torybook-3
@LastExileUA @Kandio16
Leany labs/storybook 2a (#4)
bc1ff3d 
* fix/fix-coments

* minor changes

Co-authored-by: Kandio16 <kandio1604@gmail.com>
@LastExileUA @Kandio16
Leany labs/storybook 2b (#5)
5e10ac4 
* stories/fix-comments

* stories/add-checkBox-name

Co-authored-by: Kandio16 <kandio1604@gmail.com>
@LastExileUA
fix: names for checkbox
e86518d
@LastExileUA
fix: add missing link
868ffbf
@LastExileUA
Merge branch 'mondaycom:update/hadas/storybook-3' into update/hadas/s…
9ca447e 
…torybook-3
@LastExileUA
Leany labs/storybook 3 (#6)
990dfc3 
docs: create new storybooks for Attention box, Alert banner, Toast
tests: change style and expand tests for Attention box, Alert banner, Toast
@LastExileUA @Kandio16
Leany labs/storybook 3a (#7)
ff0f47d 
* fix

* stories/fix-comments

* stories/add-toast-test

Co-authored-by: Kandio16 <kandio1604@gmail.com>
@LastExileUA @Kandio16
Leany labs/storybook 3b (#8)
572ca66 
* stories-3b/init

* stories-3b/toasts

Co-authored-by: Kandio16 <kandio1604@gmail.com>
@LastExileUA
Merge branch 'mondaycom:update/hadas/storybook-3' into update/hadas/s…
98b79ed 
…torybook-3
@Kandio16
stories/fix-demo-comments
e0594e8
@LastExileUA
refactor: remove line before closing bracket
1c541fd
@LastExileUA
Merge branch 'update/hadas/storybook-3' of https://github.com/mondayc…
82eb00b 
…om/monday-ui-react-core into mondaycom-update/hadas/storybook-3
@LastExileUA
Merge branch 'mondaycom-update/hadas/storybook-3' into update/hadas/s…
6e6f4a8 
…torybook-3
@LastExileUA
Merge branch 'mondaycom:update/hadas/storybook-3' into update/hadas/s…
cf2c618 
…torybook-3
@LastExileUA
Merge branch 'mondaycom:update/hadas/storybook-3' into update/hadas/s…
5e13c94 
…torybook-3
@LastExileUA
Merge branch 'mondaycom:update/hadas/storybook-3' into update/hadas/s…
15af5a4 
…torybook-3
@LastExileUA
Merge branch 'mondaycom:update/hadas/storybook-3' into update/hadas/s…
bd1e90b 
…torybook-3
LastExileUA and others added 18 commits December 21, 2021 19:34
hadasfa
hadasfa reviewed Dec 23, 2021
View reviewed changes
Comment thread src/components/BreadcrumbsBar/BreadcrumbItem/__tests__/breadcrumbItem-tests.jest.js
expect(tree).toMatchSnapshot();
});

describe("BreadcrumbsItem tests", () => {

@hadasfa hadasfa Dec 23, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a test for onClick prop too?

@hadasfa hadasfa Dec 26, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for later: add test with aria label

hadasfa
hadasfa reviewed Dec 23, 2021
View reviewed changes
Comment thread src/components/MultiStepIndicator/__stories__/multiStepIndicator.stories.mdx Outdated
const clearSteps = useCallback(() => {
setSteps([{ ...exampleSteps.firstStep }, { ...exampleSteps.secondStep }, { ...exampleSteps.thirdStep }]);
}, [setSteps]);
const getStepKeyForTransition = () => {

@hadasfa hadasfa Dec 23, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use here useCallback

hadasfa
hadasfa reviewed Dec 23, 2021
View reviewed changes
Comment thread src/components/MultiStepIndicator/__stories__/multiStepIndicator.stories.mdx Outdated
else if (numActions < 4) return "secondStep";
else return "thirdStep";
};
const STEP_TRANSITIONS = {

@hadasfa hadasfa Dec 23, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use useMemo for STEP_TRANSITIONS

hadasfa
hadasfa suggested changes Dec 23, 2021
View reviewed changes

@hadasfa hadasfa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! wrote few notes

hadasfa
hadasfa reviewed Dec 26, 2021
View reviewed changes
Comment thread src/components/Skeleton/__stories__/skeleton.stories.mdx

## Use cases and examples
### Update in the system
Use this menu to allow a user to either select one or more items from the list.

@hadasfa hadasfa Dec 26, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix description later

hadasfa
hadasfa reviewed Dec 26, 2021
View reviewed changes
Comment thread src/components/Tooltip/__stories__/tooltip.stories.mdx
<Tip>As tooltips only surface from a hover, never include links or buttons in the copy. If your tooltip requires either of these, considers putting your content in a
<Link href="/?path=/docs/components-tipseen--overview" size={Link.sizes.SMALL} withoutSpacing>Tipseen</Link> or
<Link href="/?path=/docs/components-attentionbox--overview" size={Link.sizes.SMALL}>Attention box.</Link>
<Link href="/?path=/docs/dialogs-and-pop-ups-tipseen--overview" size={Link.sizes.SMALL} withoutSpacing>Tipseen</Link> or

@hadasfa hadasfa Dec 26, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix to popover later

@hadasfa
hadasfa self-requested a review December 26, 2021 09:14
@hadasfa
hadasfa merged commit 4d51c96 into mondaycom:update/hadas/storybook-3 Dec 26, 2021
orrgottlieb added a commit that referenced this pull request Dec 27, 2021
@orrgottlieb @LastExileUA
@Kandio16 @ofersh-monday @sahariko
Vibe Design System Release 1.0 (#340)
a7432d5 
* first template for first story with the new format (button)

* wip

* wip: component rules

* feat: storybook helper new component (component rule)

* chore: new storybook components: header & component rules & usage guideline

* chore: new storybook components: related-components & usage guideline

* chore: new storybook tips support title, changes in button storybook page

* chore: update desgin review notes, add anchor list item design chane

* chore: add icons loading success and on color button stories

* add support on general footer

* i hate webpack....

* add stories

* fix table of contents

* support component descriptions and start working on components stories

* add component story

* add story controls

* check

* storybook stories wrapper and anchor list item margin fix

* chore: paragraph component and stories style margin fix

* chore: undo paragraph change

* change tabs order

* change tabs order

* chore: change names of storybook helpers title for more declerative names

* chore: readme files for component name, section name and tip

* chore: readme files for related components, usage guidelines, tip and anchor

* chore: readme for title and related component

* update plop according to new story changes

* update plop according to new story changes

* update tests readme & tests plop

* fix bug on plop

* fix readme

* naming fixs

* plop: fix mock examples

* sos

* support mdx file structure

* fix imports in storybook components

* support display all stories inside the mdx file

* update from master

* remove component name attention box dependency

* fix table of contents

* fix table of contents

* update new component plop

* update new component plop

* update new component plop

* create plops for tests and stories for exist component

* fix according to code review notes for component rules

* undo not needed changes

* remove not needed file

* add links support to stories (#334)

* add links support to stories

* undo not needed changes

* Leany labs/storybook 1 (#1) (#329)

* Leany labs/storybook 1 (#1)

* story: avatar-init

* stories: chips

* stories/delete-old-stories

* stories/add-label

* stories/toggle-init

* stories/add-ArgsTable

* stories/toggle-init

* stories/add-checkbox

* stories/add-radioButton

* stories/fix-btn-group

* stories/add-src

* stories/fix

* stories/add-search-bar-ui

* stories/search-person-column

* stories/fix

* stories/fix

* stories/fix

* chip/test/init

* test/add-chips-tests

* clean up

* stories/add-icons

* stories/add-components

* stories/fix-icons-name

* stories/small-refactoring

* stories/little-fix

* stories/fix

* test/add-tests-plop

* change styling

* remove unused files

* add spaces

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 1 (#2)

docs: create new storybooks for Avatar, Chip, Toggle
tests: change style and expend tests for Avatar, Chip, Toggle, Button

* remove obsolete snapshot

* revert Button test

* remove spaces

* chips: style tests

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Chromatic (storybook 6.4) (#326)

* feat: chromatic

* feat:  temp

* feat: small fixes

* wip: Buttun Sizes

* hooks: story

* i hate this

* hooks stories and adjustments

* PR comments

* small adjustments

* feat: Icon Button Stories

* test: something

* tests!

* lint: fix

* lint: fix #2

* feat: 6.4 version

* fix spacing in links (#338)

* Storybook/hadas/welcome (#337)

* start working on welcome page

* wip

* wip

* welcome page

* pictuers fix

* pictuers fix & banner fix

* fix

* fix

* fix

* fix

* fix

* add contributors list with githubs

* add contributors list with github links to welcome page

* fix linter !

* update from master

* Fix fonts and spacing according to rotem notes (#343)

* fix fonts and spacing according to rotem notes

* fix style error

* fix style error

* fix: AlertBanner in MDX

* LeanyLabs: storybooks & tests (Label, Checkbox, Radio button) (#342)

* Leany labs/storybook 1 (#1)

* story: avatar-init

* stories: chips

* stories/delete-old-stories

* stories/add-label

* stories/toggle-init

* stories/add-ArgsTable

* stories/toggle-init

* stories/add-checkbox

* stories/add-radioButton

* stories/fix-btn-group

* stories/add-src

* stories/fix

* stories/add-search-bar-ui

* stories/search-person-column

* stories/fix

* stories/fix

* stories/fix

* chip/test/init

* test/add-chips-tests

* clean up

* stories/add-icons

* stories/add-components

* stories/fix-icons-name

* stories/small-refactoring

* stories/little-fix

* stories/fix

* test/add-tests-plop

* change styling

* remove unused files

* add spaces

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 1 (#2)

docs: create new storybooks for Avatar, Chip, Toggle
tests: change style and expend tests for Avatar, Chip, Toggle, Button

* remove obsolete snapshot

* revert Button test

* remove spaces

* chips: style tests

* LeanyLabs/storybook 2 (#3)

* story: avatar-init

* stories: chips

* stories/delete-old-stories

* stories/add-label

* stories/toggle-init

* stories/add-ArgsTable

* stories/toggle-init

* stories/add-checkbox

* stories/add-radioButton

* stories/fix-btn-group

* stories/add-src

* stories/fix

* stories/add-search-bar-ui

* stories/search-person-column

* stories/fix

* stories/fix

* stories/fix

* chip/test/init

* test/add-chips-tests

* clean up

* stories/add-icons

* stories/add-components

* stories/fix-icons-name

* stories/small-refactoring

* stories/little-fix

* stories/fix

* test/add-tests-plop

* stories/add-link

* stories/label-init

* stories/add-radio-button

* stories/add-RC

* stories/add-checkbox

* stories/fix-comments

* stories/add

* stories/fix

* stories/merge

* stories/some-fix

* tests/add-tests

* stories/add-link

* stories/fix

* stories/add-size

* fix: small changes in checkbox stories

* polishig

* renamed file according to styles

* polishing

* polishing

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 2a (#4)

* fix/fix-coments

* minor changes

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 2b (#5)

* stories/fix-comments

* stories/add-checkBox-name

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* fix: names for checkbox

* fix: add missing link

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* LeanyLabs #3: Attention box, Alert banner, Toast (#355)

* Leany labs/storybook 1 (#1)

* story: avatar-init

* stories: chips

* stories/delete-old-stories

* stories/add-label

* stories/toggle-init

* stories/add-ArgsTable

* stories/toggle-init

* stories/add-checkbox

* stories/add-radioButton

* stories/fix-btn-group

* stories/add-src

* stories/fix

* stories/add-search-bar-ui

* stories/search-person-column

* stories/fix

* stories/fix

* stories/fix

* chip/test/init

* test/add-chips-tests

* clean up

* stories/add-icons

* stories/add-components

* stories/fix-icons-name

* stories/small-refactoring

* stories/little-fix

* stories/fix

* test/add-tests-plop

* change styling

* remove unused files

* add spaces

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 1 (#2)

docs: create new storybooks for Avatar, Chip, Toggle
tests: change style and expend tests for Avatar, Chip, Toggle, Button

* remove obsolete snapshot

* revert Button test

* remove spaces

* chips: style tests

* LeanyLabs/storybook 2 (#3)

* story: avatar-init

* stories: chips

* stories/delete-old-stories

* stories/add-label

* stories/toggle-init

* stories/add-ArgsTable

* stories/toggle-init

* stories/add-checkbox

* stories/add-radioButton

* stories/fix-btn-group

* stories/add-src

* stories/fix

* stories/add-search-bar-ui

* stories/search-person-column

* stories/fix

* stories/fix

* stories/fix

* chip/test/init

* test/add-chips-tests

* clean up

* stories/add-icons

* stories/add-components

* stories/fix-icons-name

* stories/small-refactoring

* stories/little-fix

* stories/fix

* test/add-tests-plop

* stories/add-link

* stories/label-init

* stories/add-radio-button

* stories/add-RC

* stories/add-checkbox

* stories/fix-comments

* stories/add

* stories/fix

* stories/merge

* stories/some-fix

* tests/add-tests

* stories/add-link

* stories/fix

* stories/add-size

* fix: small changes in checkbox stories

* polishig

* renamed file according to styles

* polishing

* polishing

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 2a (#4)

* fix/fix-coments

* minor changes

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 2b (#5)

* stories/fix-comments

* stories/add-checkBox-name

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* fix: names for checkbox

* fix: add missing link

* Leany labs/storybook 3 (#6)

docs: create new storybooks for Attention box, Alert banner, Toast
tests: change style and expand tests for Attention box, Alert banner, Toast

* Leany labs/storybook 3a (#7)

* fix

* stories/fix-comments

* stories/add-toast-test

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 3b (#8)

* stories-3b/init

* stories-3b/toasts

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* stories/fix-demo-comments

* refactor: remove line before closing bracket

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* use callback fix

* merge with master

* feat: fix chromatic deploy

* Storybook/hadasfa/design fix (#362)

* design fix: font weight

* design fix: related components cells width

* try fix errors with eslint and storybook jest

* try fix errors with eslint and storybook jest

* fix usage guidelines multiline support

* fix usage guidelines multiline support

* LeanyLabs/storybook#4 (#359)

* Leany labs/storybook 1 (#1)

* story: avatar-init

* stories: chips

* stories/delete-old-stories

* stories/add-label

* stories/toggle-init

* stories/add-ArgsTable

* stories/toggle-init

* stories/add-checkbox

* stories/add-radioButton

* stories/fix-btn-group

* stories/add-src

* stories/fix

* stories/add-search-bar-ui

* stories/search-person-column

* stories/fix

* stories/fix

* stories/fix

* chip/test/init

* test/add-chips-tests

* clean up

* stories/add-icons

* stories/add-components

* stories/fix-icons-name

* stories/small-refactoring

* stories/little-fix

* stories/fix

* test/add-tests-plop

* change styling

* remove unused files

* add spaces

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 1 (#2)

docs: create new storybooks for Avatar, Chip, Toggle
tests: change style and expend tests for Avatar, Chip, Toggle, Button

* remove obsolete snapshot

* revert Button test

* remove spaces

* chips: style tests

* LeanyLabs/storybook 2 (#3)

* story: avatar-init

* stories: chips

* stories/delete-old-stories

* stories/add-label

* stories/toggle-init

* stories/add-ArgsTable

* stories/toggle-init

* stories/add-checkbox

* stories/add-radioButton

* stories/fix-btn-group

* stories/add-src

* stories/fix

* stories/add-search-bar-ui

* stories/search-person-column

* stories/fix

* stories/fix

* stories/fix

* chip/test/init

* test/add-chips-tests

* clean up

* stories/add-icons

* stories/add-components

* stories/fix-icons-name

* stories/small-refactoring

* stories/little-fix

* stories/fix

* test/add-tests-plop

* stories/add-link

* stories/label-init

* stories/add-radio-button

* stories/add-RC

* stories/add-checkbox

* stories/fix-comments

* stories/add

* stories/fix

* stories/merge

* stories/some-fix

* tests/add-tests

* stories/add-link

* stories/fix

* stories/add-size

* fix: small changes in checkbox stories

* polishig

* renamed file according to styles

* polishing

* polishing

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 2a (#4)

* fix/fix-coments

* minor changes

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* stories/init

* stories/add-btn-group-scss

* sotries/counter-add-styles

* Leany labs/storybook 2b (#5)

* stories/fix-comments

* stories/add-checkBox-name

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* fix: names for checkbox

* fix: add missing link

* stories/btn-group-add-links

* stories/counter-styles

* stories/litle-fix

* stories/add-RC

* stories/add-icon

* Leany labs/storybook 3 (#6)

docs: create new storybooks for Attention box, Alert banner, Toast
tests: change style and expand tests for Attention box, Alert banner, Toast

* stories/add-counter-tests

* stories/split-button-tests

* stories/buttonGroup-tests-init

* stories/add-tests

* fix: split button

* fix: split button call

* stories/split-btn

* stories/fix

* ffix

* stories/split-button-styles

* stories/add-counter-animation

* stories/split-btn-padding

* Leany labs/storybook 3a (#7)

* fix

* stories/fix-comments

* stories/add-toast-test

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 3b (#8)

* stories-3b/init

* stories-3b/toasts

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* fix: add lines

* stories/fix-demo-comments

* refactor: remove line before closing bracket

* stories/fix-comments

* stories/split-button-fix

* fix: styling; chips; toast

* stories-change-value

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* fix counter

* fix typ

* Leany labs/storybook 5 (#372)

* Leany labs/storybook 1 (#1)

* story: avatar-init

* stories: chips

* stories/delete-old-stories

* stories/add-label

* stories/toggle-init

* stories/add-ArgsTable

* stories/toggle-init

* stories/add-checkbox

* stories/add-radioButton

* stories/fix-btn-group

* stories/add-src

* stories/fix

* stories/add-search-bar-ui

* stories/search-person-column

* stories/fix

* stories/fix

* stories/fix

* chip/test/init

* test/add-chips-tests

* clean up

* stories/add-icons

* stories/add-components

* stories/fix-icons-name

* stories/small-refactoring

* stories/little-fix

* stories/fix

* test/add-tests-plop

* change styling

* remove unused files

* add spaces

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 1 (#2)

docs: create new storybooks for Avatar, Chip, Toggle
tests: change style and expend tests for Avatar, Chip, Toggle, Button

* remove obsolete snapshot

* revert Button test

* remove spaces

* chips: style tests

* LeanyLabs/storybook 2 (#3)

* story: avatar-init

* stories: chips

* stories/delete-old-stories

* stories/add-label

* stories/toggle-init

* stories/add-ArgsTable

* stories/toggle-init

* stories/add-checkbox

* stories/add-radioButton

* stories/fix-btn-group

* stories/add-src

* stories/fix

* stories/add-search-bar-ui

* stories/search-person-column

* stories/fix

* stories/fix

* stories/fix

* chip/test/init

* test/add-chips-tests

* clean up

* stories/add-icons

* stories/add-components

* stories/fix-icons-name

* stories/small-refactoring

* stories/little-fix

* stories/fix

* test/add-tests-plop

* stories/add-link

* stories/label-init

* stories/add-radio-button

* stories/add-RC

* stories/add-checkbox

* stories/fix-comments

* stories/add

* stories/fix

* stories/merge

* stories/some-fix

* tests/add-tests

* stories/add-link

* stories/fix

* stories/add-size

* fix: small changes in checkbox stories

* polishig

* renamed file according to styles

* polishing

* polishing

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 2a (#4)

* fix/fix-coments

* minor changes

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 2b (#5)

* stories/fix-comments

* stories/add-checkBox-name

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* fix: names for checkbox

* fix: add missing link

* Leany labs/storybook 3 (#6)

docs: create new storybooks for Attention box, Alert banner, Toast
tests: change style and expand tests for Attention box, Alert banner, Toast

* stories/init

* styles

* Leany labs/storybook 3a (#7)

* fix

* stories/fix-comments

* stories/add-toast-test

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 3b (#8)

* stories-3b/init

* stories-3b/toasts

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* stories/init

* stories/add-args

* stories/tooltip-init

* stories/fix-demo-comments

* refactor: remove line before closing bracket

* remove

* stories/link-init

* stories/search-init

* stories/text-field-init

* stories/link-rc

* stories/add-link-tests

* stories/search-tests-init

* stories/test-init

* stories/add-text-field-snapshot-tests

* stories/input-tests

* stories/add-RC

* stories/links

* stories/delete-fiels

* stories/fix

* tests-fix

* add-test-aria-label

* fix-combobox-RC

* fix-link

* stories/fix-styles

* fix: some styling

* fix: styling

* fix: remove stale text in variants for Links

* fix: placeholders

* mend

* Leany labs/storybook 5a (#11)

* stories/fix-comments

* stories/minor-fix

Co-authored-by: Kandio16 <kandio1604@gmail.com>

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Test/orr/migrate karma to jest (#379)

* feat: move to jest

* Butotn tests

* Link Tests

* Link Tests

* test: FormattedNumber

* test: Loader

* test: small changes

* ifnra: update test

* remove: karma sinon and mocha

* remove: karma sinon and mocha

* test: update coverage

* fix: testing

* fix: testing

* fix: lint

* fix: lint and stylelint

* fix: storyshoots tests

* uupdate node-sass

* remove errors

* fix accordion item type check

* Storybook/hadas/typography (#383)

* add typography story

* remove old typography story

* fix frame border

* fix code review notes

* expose colors-utils (#385)

* expose colors-utils

* pr fix

* undo delete accordion type check

Co-authored-by: Ofer Shapira <ofersh@monday.com>

* Storybook/hadas/menu reorder (#393)

* change menu order 1

* change menu order 2

* change menu order 3

* change names after talking with evigeny

* Leany labs/storybook 6 (#380)

* Leany labs/storybook 1 (#1)

* story: avatar-init

* stories: chips

* stories/delete-old-stories

* stories/add-label

* stories/toggle-init

* stories/add-ArgsTable

* stories/toggle-init

* stories/add-checkbox

* stories/add-radioButton

* stories/fix-btn-group

* stories/add-src

* stories/fix

* stories/add-search-bar-ui

* stories/search-person-column

* stories/fix

* stories/fix

* stories/fix

* chip/test/init

* test/add-chips-tests

* clean up

* stories/add-icons

* stories/add-components

* stories/fix-icons-name

* stories/small-refactoring

* stories/little-fix

* stories/fix

* test/add-tests-plop

* change styling

* remove unused files

* add spaces

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 1 (#2)

docs: create new storybooks for Avatar, Chip, Toggle
tests: change style and expend tests for Avatar, Chip, Toggle, Button

* remove obsolete snapshot

* revert Button test

* remove spaces

* chips: style tests

* LeanyLabs/storybook 2 (#3)

* story: avatar-init

* stories: chips

* stories/delete-old-stories

* stories/add-label

* stories/toggle-init

* stories/add-ArgsTable

* stories/toggle-init

* stories/add-checkbox

* stories/add-radioButton

* stories/fix-btn-group

* stories/add-src

* stories/fix

* stories/add-search-bar-ui

* stories/search-person-column

* stories/fix

* stories/fix

* stories/fix

* chip/test/init

* test/add-chips-tests

* clean up

* stories/add-icons

* stories/add-components

* stories/fix-icons-name

* stories/small-refactoring

* stories/little-fix

* stories/fix

* test/add-tests-plop

* stories/add-link

* stories/label-init

* stories/add-radio-button

* stories/add-RC

* stories/add-checkbox

* stories/fix-comments

* stories/add

* stories/fix

* stories/merge

* stories/some-fix

* tests/add-tests

* stories/add-link

* stories/fix

* stories/add-size

* fix: small changes in checkbox stories

* polishig

* renamed file according to styles

* polishing

* polishing

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 2a (#4)

* fix/fix-coments

* minor changes

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 2b (#5)

* stories/fix-comments

* stories/add-checkBox-name

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* fix: names for checkbox

* fix: add missing link

* Leany labs/storybook 3 (#6)

docs: create new storybooks for Attention box, Alert banner, Toast
tests: change style and expand tests for Attention box, Alert banner, Toast

* Leany labs/storybook 3a (#7)

* fix

* stories/fix-comments

* stories/add-toast-test

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 3b (#8)

* stories-3b/init

* stories-3b/toasts

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* stories/fix-demo-comments

* refactor: remove line before closing bracket

* stories/steps-init

* stories/tipseen-init

* steps/tests-init

* stories/tooltip-init

* stories/tipseen-styles-init

* stories/styles-tooltip

* stories/tooltip-tests-init

* stories/steps-clear

* stories/steps-fix

* stories/tipseen-styles

* stories/tooltip

* stories/tooltip-styles

* RC-Links

* fix-steps

* fix-styles-steps

* tipseen-snapshot-tests

* fix-after-chromatic-review

* remove-class

* tipseen-clear

* fix

* tooltip-tests

* fix: rename files

* fix: line gaps

* fix-coments

* fix-comments

* tipseen-fix-children

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Change new stories positions and rename variables in the steps stories page

* fix tests of tooltip

* remove accordion type check

* add class name support

* Storybook/hadas/spacing page (#392)

* spacing page wip

* spacing story - add spacing sizes component

* spacing story - remove old spacing story

* add temp assets until receiving good assets

* fix spacing assets

* fix spacing assets

* fix spacing in spacing component

* code review notes

* Storybook/hadas/shadow (#394)

* add shadow story

* change names after talking with evigeny

* add assets and shadow example design

* add use cases examples for shadow

* remove not needed import

* not real

* add asset to shadow example (card)

* code review notes

* Feat/orr/stories rest (#395)

* ColorPicker

* Clickable

* DialogContentContainer.jsx

* Editable Header

* Loader

* PR: review

* Change SASS loader package (#398)

* css import issues

* fix some importing issue

* node 12

* fix: double style elements

* fix build

* fix tests

* Storybook/hadas/colors function page (#397)

* add basic implementation of the colors page

* add content colors and typography-description

* colors foundation assets

* fix hover error

* add dependency array

* Leany labs/storybook 7 (#396)

* Leany labs/storybook 1 (#1)

* story: avatar-init

* stories: chips

* stories/delete-old-stories

* stories/add-label

* stories/toggle-init

* stories/add-ArgsTable

* stories/toggle-init

* stories/add-checkbox

* stories/add-radioButton

* stories/fix-btn-group

* stories/add-src

* stories/fix

* stories/add-search-bar-ui

* stories/search-person-column

* stories/fix

* stories/fix

* stories/fix

* chip/test/init

* test/add-chips-tests

* clean up

* stories/add-icons

* stories/add-components

* stories/fix-icons-name

* stories/small-refactoring

* stories/little-fix

* stories/fix

* test/add-tests-plop

* change styling

* remove unused files

* add spaces

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 1 (#2)

docs: create new storybooks for Avatar, Chip, Toggle
tests: change style and expend tests for Avatar, Chip, Toggle, Button

* remove obsolete snapshot

* revert Button test

* remove spaces

* chips: style tests

* LeanyLabs/storybook 2 (#3)

* story: avatar-init

* stories: chips

* stories/delete-old-stories

* stories/add-label

* stories/toggle-init

* stories/add-ArgsTable

* stories/toggle-init

* stories/add-checkbox

* stories/add-radioButton

* stories/fix-btn-group

* stories/add-src

* stories/fix

* stories/add-search-bar-ui

* stories/search-person-column

* stories/fix

* stories/fix

* stories/fix

* chip/test/init

* test/add-chips-tests

* clean up

* stories/add-icons

* stories/add-components

* stories/fix-icons-name

* stories/small-refactoring

* stories/little-fix

* stories/fix

* test/add-tests-plop

* stories/add-link

* stories/label-init

* stories/add-radio-button

* stories/add-RC

* stories/add-checkbox

* stories/fix-comments

* stories/add

* stories/fix

* stories/merge

* stories/some-fix

* tests/add-tests

* stories/add-link

* stories/fix

* stories/add-size

* fix: small changes in checkbox stories

* polishig

* renamed file according to styles

* polishing

* polishing

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 2a (#4)

* fix/fix-coments

* minor changes

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 2b (#5)

* stories/fix-comments

* stories/add-checkBox-name

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* fix: names for checkbox

* fix: add missing link

* Leany labs/storybook 3 (#6)

docs: create new storybooks for Attention box, Alert banner, Toast
tests: change style and expand tests for Attention box, Alert banner, Toast

* Leany labs/storybook 3a (#7)

* fix

* stories/fix-comments

* stories/add-toast-test

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 3b (#8)

* stories-3b/init

* stories-3b/toasts

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* stories/fix-demo-comments

* refactor: remove line before closing bracket

* accordian-init

* tab-init

* tabs-init

* test-version

* remove-border

* fix

* fix-tab

* tabs-fix

* tabs-fix-bg-color

* accordion-styles

* prog-bar-init

* progressBar-styles

* accordion-fix

* accordion-remove

* accardion-rc

* proggressBar-RC

* refactoring

* rename-tabs

* tabs-RC

* accordion-tests-init

* progressBar-styles

* fix-to-uppercase

* tabs-snapshot

* progressBar-snapshot-tests

* progressBar-tests

* fix-coments

* add-RC

* fix-rc

* accordion-styles

* fix: tabs overview

* accordin-tests

* tab-tests

* tabList-tests

* tabPanel-tests

* tabPanels-tests

* tabsContext-tests

* tabs-column-styles

* fix-coments

* fix: some text

* fix: empty lines

* fix-coments

* fix: identations

* fix: identations

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Storybook/hadas/template (#399)

* update template according to new branding part 1

* template update according to new brand

* code review fix

* design review changes

* change menu order for new components

* WIP: Coming soon & fix tests errors (css and js) (#400)

* coming soon foundation pages

* fix imports

* fix tests

* fix css and js tests error

* fix css and js tests error

* fix css and js tests error

* fix css and js tests error

* fix css and js tests error

* fix css and js tests error

* fix css and js tests error

* Storybook/hadas/controls infra (#402)

* fix some prop types and start of controls infra implementation

* undo

* clean up and some styles

* fix style

* LeanyLabs/storybook 8 (#403)

* Leany labs/storybook 1 (#1)

* story: avatar-init

* stories: chips

* stories/delete-old-stories

* stories/add-label

* stories/toggle-init

* stories/add-ArgsTable

* stories/toggle-init

* stories/add-checkbox

* stories/add-radioButton

* stories/fix-btn-group

* stories/add-src

* stories/fix

* stories/add-search-bar-ui

* stories/search-person-column

* stories/fix

* stories/fix

* stories/fix

* chip/test/init

* test/add-chips-tests

* clean up

* stories/add-icons

* stories/add-components

* stories/fix-icons-name

* stories/small-refactoring

* stories/little-fix

* stories/fix

* test/add-tests-plop

* change styling

* remove unused files

* add spaces

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 1 (#2)

docs: create new storybooks for Avatar, Chip, Toggle
tests: change style and expend tests for Avatar, Chip, Toggle, Button

* remove obsolete snapshot

* revert Button test

* remove spaces

* chips: style tests

* LeanyLabs/storybook 2 (#3)

* story: avatar-init

* stories: chips

* stories/delete-old-stories

* stories/add-label

* stories/toggle-init

* stories/add-ArgsTable

* stories/toggle-init

* stories/add-checkbox

* stories/add-radioButton

* stories/fix-btn-group

* stories/add-src

* stories/fix

* stories/add-search-bar-ui

* stories/search-person-column

* stories/fix

* stories/fix

* stories/fix

* chip/test/init

* test/add-chips-tests

* clean up

* stories/add-icons

* stories/add-components

* stories/fix-icons-name

* stories/small-refactoring

* stories/little-fix

* stories/fix

* test/add-tests-plop

* stories/add-link

* stories/label-init

* stories/add-radio-button

* stories/add-RC

* stories/add-checkbox

* stories/fix-comments

* stories/add

* stories/fix

* stories/merge

* stories/some-fix

* tests/add-tests

* stories/add-link

* stories/fix

* stories/add-size

* fix: small changes in checkbox stories

* polishig

* renamed file according to styles

* polishing

* polishing

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 2a (#4)

* fix/fix-coments

* minor changes

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 2b (#5)

* stories/fix-comments

* stories/add-checkBox-name

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* fix: names for checkbox

* fix: add missing link

* Leany labs/storybook 3 (#6)

docs: create new storybooks for Attention box, Alert banner, Toast
tests: change style and expand tests for Attention box, Alert banner, Toast

* Leany labs/storybook 3a (#7)

* fix

* stories/fix-comments

* stories/add-toast-test

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Leany labs/storybook 3b (#8)

* stories-3b/init

* stories-3b/toasts

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* stories/fix-demo-comments

* refactor: remove line before closing bracket

* skeleton-init

* breadcrumbs-styles

* wizard-init

* remove-RC

* wizard-styles

* add-RC

* skeleton-useCase

* skeleton-tests-clear

* wizard-tests-init

* fix

* fix-href

* fix-href

* wizard-tests

* breadcrumbs-tests

* fix-href

* fix-coments

* fix: minor changes

* fix: minor

* fix: replace formating

* fix: replace formating

* fix

Co-authored-by: Kandio16 <kandio1604@gmail.com>

* Add `useAfterFirstRender` story (#406)

* menu & shadow description and more (#405)

* wip

* wip

* wip

* Fix typos and add related components

* code review notes

* fix snapshot tests

* design review notes

* WIP: divider, list and more (#409)

* divider and popover links and list stories fixes

* last fixes in list

* text with high lights

* add nick to contributors, and fix colors page

* fix controls

* fix

* Add `useDebounceEvent` stories (#410)

* Heading and spacing description (#408)

* wip heading component

* heading story

* wip

* wip

* heading component

* create description for the spacing

* spacing description and fix controls

* spacing description and fix controls

* spacing description and fix controls

* Move existing hooks stories next to them (#407)

* Storybook/hadas/final tweeks (#411)

* fix errors

* fix errors

* fix import ordr

* Stories/orr/icons responsivelist virtualized list (#412)

* icon

* ResponsiveList

* ResponsiveList

* VirtualizedList

* Menu Button

* Menu Button

* MenuButton and Virtualized

* remove

* navigtion fix

* small fix

* fix some stuff

* lint

* Add `useKeyEvent` story (#413)

Co-authored-by: Orr Gottlieb <orr@monday.com>
Co-authored-by: Ivan Harasymchuk <ivan7790@gmail.com>
Co-authored-by: Kandio16 <kandio1604@gmail.com>
Co-authored-by: Orr Gottlieb <60314759+orrgottlieb@users.noreply.github.com>
Co-authored-by: Ofer Shapira <ofersh@monday.com>
Co-authored-by: Sahar Brodbeker <saharonb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@hadasfa hadasfa hadasfa approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LastExileUA @hadasfa @Kandio16