Rebase fork onto rust-lightning v0.2.5

.envrc

@@ -0,0 +1 @@
+use flake

.github/workflows/build.yml

@@ -20,7 +20,7 @@ jobs:
         uses: actions/checkout@v4
       - name: Install Rust stable toolchain
         run: |
-          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable
+          rustup default stable
       - name: Run externalized tests
         run: |
           cd ext-functional-test-demo
@@ -45,7 +45,7 @@ jobs:
         uses: actions/checkout@v4
       - name: Install Rust ${{ matrix.toolchain }} toolchain
         run: |
-          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ matrix.toolchain }}
+          rustup default ${{ matrix.toolchain }}
       - name: Use rust-lld linker on Windows
         if: matrix.platform == 'windows-latest'
         shell: bash
@@ -78,7 +78,7 @@ jobs:
         uses: actions/checkout@v4
       - name: Install Rust ${{ matrix.toolchain }} toolchain
         run: |
-          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ matrix.toolchain }}
+          rustup default ${{ matrix.toolchain }}
       - name: Set RUSTFLAGS to deny warnings
         if: "matrix.toolchain == '1.75.0'"
         run: echo "RUSTFLAGS=-D warnings" >> "$GITHUB_ENV"
@@ -120,7 +120,7 @@ jobs:
           fetch-depth: 0
       - name: Install Rust stable toolchain
         run: |
-          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal
+          rustup default stable
       - name: Run tests with coverage generation
         run: |
           cargo install cargo-llvm-cov
@@ -150,7 +150,7 @@ jobs:
         uses: actions/checkout@v4
       - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
         run: |
-          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
+          rustup default ${{ env.TOOLCHAIN }}
       - name: Cache routing graph snapshot
         id: cache-graph
         uses: actions/cache@v4
@@ -216,7 +216,7 @@ jobs:
           fetch-depth: 0
       - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
         run: |
-          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
+          rustup default ${{ env.TOOLCHAIN }}
       - name: Run cargo check for release build.
         run: |
           cargo check --release
@@ -247,7 +247,7 @@ jobs:
           fetch-depth: 0
       - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
         run: |
-          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
+          rustup default ${{ env.TOOLCHAIN }}
       - name: Simulate docs.rs build
         run: ci/check-docsrs.sh
 
@@ -260,11 +260,21 @@ jobs:
         uses: actions/checkout@v4
       - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
         run: |
-          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
+          rustup default ${{ env.TOOLCHAIN }}
       - name: Pin the syn and regex dependencies
         run: |
-          cd fuzz && cargo update -p regex --precise "1.9.6" && cargo update -p syn --precise "2.0.106" && cargo update -p quote --precise "1.0.41"
-          cd write-seeds && cargo update -p regex --precise "1.9.6" && cargo update -p syn --precise "2.0.106" && cargo update -p quote --precise "1.0.41"
+          cd fuzz && cargo update -p regex --precise "1.9.6" && cargo update -p serde --precise "1.0.228" && cargo update -p syn --precise "2.0.106" && cargo update -p quote --precise "1.0.41"
+          cargo update -p proc-macro2 --precise "1.0.103" --verbose && cargo update -p serde_json --precise "1.0.145" --verbose
+          cargo update -p itoa --precise "1.0.15" --verbose && cargo update -p ryu --precise "1.0.20" --verbose
+          cargo update -p libc --precise 0.2.183
+          cargo update -p unicode-ident --precise 1.0.22
+          cargo update -p honggfuzz --precise 0.5.59
+          cargo update -p semver --precise 1.0.27
+          cd write-seeds && cargo update -p regex --precise "1.9.6" && cargo update -p serde --precise "1.0.228" && cargo update -p syn --precise "2.0.106" && cargo update -p quote --precise "1.0.41"
+          cargo update -p proc-macro2 --precise "1.0.103" --verbose && cargo update -p serde_json --precise "1.0.145" --verbose
+          cargo update -p itoa --precise "1.0.15" --verbose && cargo update -p ryu --precise "1.0.20" --verbose
+          cargo update -p libc --precise 0.2.183
+          cargo update -p unicode-ident --precise 1.0.22
       - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
         run: |
           cd fuzz
@@ -282,7 +292,7 @@ jobs:
         uses: actions/checkout@v4
       - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
         run: |
-          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
+          rustup default ${{ env.TOOLCHAIN }}
       - name: Install clippy
         run: |
           rustup component add clippy
@@ -299,7 +309,7 @@ jobs:
         uses: actions/checkout@v4
       - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
         run: |
-          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
+          rustup default ${{ env.TOOLCHAIN }}
       - name: Install rustfmt
         run: |
           rustup component add rustfmt

.github/workflows/check_commits.yml

@@ -21,7 +21,7 @@ jobs:
           fetch-depth: 0
       - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
         run: |
-          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
+          rustup default ${{ env.TOOLCHAIN }}
       - name: Fetch full tree and rebase on upstream
         run: |
           git remote add upstream https://github.com/lightningdevkit/rust-lightning

.github/workflows/check_unicode.yml

@@ -0,0 +1,26 @@
+name: Unicode listing up to date
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '42 3 * * *'
+
+jobs:
+  check-unicode:
+    runs-on: ubuntu-latest
+    permissions:
+      issues: write
+    steps:
+      - name: Checkout source code
+        uses: actions/checkout@v4
+      - name: Check unicode file state
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          curl --proto '=https' --tlsv1.2 -fsSL -o /tmp/UnicodeData.txt https://www.unicode.org/Public/UCD/latest/ucd/UnicodeData.txt
+          contrib/gen_unicode_general_category.py /tmp/UnicodeData.txt -o /tmp/unicode.rs
+          if ! diff -u lightning-types/src/unicode.rs /tmp/unicode.rs; then
+            TITLE="Unicode listing out of date: ${{ github.workflow }}"
+            RUN_URL="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
+            BODY="The unicode character listing is out of date, see $RUN_URL"
+            gh issue create --title "$TITLE" --body "$BODY"
+          fi

.github/workflows/semver.yml

@@ -9,48 +9,24 @@ on:
 
 jobs:
   semver-checks:
-    runs-on: ubuntu-latest
+    runs-on: debian-trixie
     steps:
       - name: Checkout source code
         uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
       - name: Install Rust stable toolchain
         run: |
-          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable
+          rustup default stable
           rustup override set stable
-      - name: Check SemVer with default features
-        uses: obi1kenobi/cargo-semver-checks-action@v2
-        with:
-            feature-group: default-features
-      - name: Check SemVer *without* default features
-        uses: obi1kenobi/cargo-semver-checks-action@v2
-        with:
-            feature-group: only-explicit-features
-      - name: Check lightning-background-processor SemVer
-        uses: obi1kenobi/cargo-semver-checks-action@v2
-        with:
-            package: lightning-background-processor
-            feature-group: only-explicit-features
-      - name: Check lightning-block-sync SemVer
-        uses: obi1kenobi/cargo-semver-checks-action@v2
-        with:
-            package: lightning-block-sync
-            feature-group: only-explicit-features
-            features: rpc-client,rest-client
-      - name: Check lightning-transaction-sync electrum SemVer
-        uses: obi1kenobi/cargo-semver-checks-action@v2
-        with:
-            manifest-path: lightning-transaction-sync/Cargo.toml
-            feature-group: only-explicit-features
-            features: electrum
-      - name: Check lightning-transaction-sync esplora-blocking SemVer
-        uses: obi1kenobi/cargo-semver-checks-action@v2
-        with:
-            manifest-path: lightning-transaction-sync/Cargo.toml
-            feature-group: only-explicit-features
-            features: esplora-blocking
-      - name: Check lightning-transaction-sync esplora-async SemVer
-        uses: obi1kenobi/cargo-semver-checks-action@v2
-        with:
-            manifest-path: lightning-transaction-sync/Cargo.toml
-            feature-group: only-explicit-features
-            features: esplora-async
+      - name: Install SemVer Checker
+        run: cargo install cargo-semver-checks --locked
+      - name: Check SemVer with all features
+        run: cargo semver-checks
+      - name: Check SemVer without any non-default features
+        run: cargo semver-checks --only-explicit-features
+      - name: Check lightning-transaction-sync SemVer
+        run: |
+          cd lightning-transaction-sync
+          cargo semver-checks
+          cargo semver-checks --only-explicit-features