Skip to content

fix(crud): menu not fully showing for field actions, remove old backgrounds COMPASS-6186 #3574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 13, 2022
Merged

fix(crud): menu not fully showing for field actions, remove old backgrounds COMPASS-6186 #3574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
59ebcfd
fix menu not showing fully in crud, remove old backgrounds in keyline…
Anemy Oct 11, 2022
fafe5ff
remove extra ref
Anemy Oct 11, 2022
c64bfac
Merge branch 'main' into COMPASS-6186-fix-menus-in-crud
Anemy Oct 11, 2022
1c14a58
remove drop shadow on editing documents
Anemy Oct 12, 2022
9dc3a95
Merge branch 'main' into COMPASS-6186-fix-menus-in-crud
mcasimir Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/compass-components/src/components/document-list/document-edit-actions-footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,8 @@ const container = css({
paddingLeft: spacing[3],
alignItems: 'center',
gap: spacing[2],
borderBottomLeftRadius: 'inherit',
borderBottomRightRadius: 'inherit',
});

const message = css({
Expand Down
1 change: 0 additions & 1 deletion packages/compass-components/src/components/keyline-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { withTheme } from '../hooks/use-theme';
const keylineStyles = css({
border: `1px solid ${palette.gray.light2}`,
borderRadius: spacing[2],
overflow: 'hidden',
});

const keylineLightThemeStyles = css({
Expand Down
3 changes: 1 addition & 2 deletions packages/compass-crud/src/components/document-json-view.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,11 @@
margin-bottom: 5px;

.json-document-is-editing {
box-shadow: 2px 5px 8px fade(@palette__black, 20%);
border-radius: inherit;
Copy link
Collaborator

@mcasimir mcasimir Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice trick, didn't know that we could have done this!

}

.json-ace-editor {
padding: 10px 10px 10px 0;
background: @palette__white;
overflow: auto;
flex-basis: auto;
flex-shrink: 1;
Expand Down
6 changes: 1 addition & 5 deletions packages/compass-crud/src/components/document-list.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,13 @@
list-style: none;
position: relative;
width: 100%;
margin-bottom: 16px;
margin-bottom: 32px;
padding-bottom: 16px;

&-item {
position: relative;
margin-bottom: 5px;

.document {
background: @palette__white;
}

&:last-child {
margin-bottom: 0;
padding-bottom: 16px;
Expand Down
10 changes: 1 addition & 9 deletions packages/compass-crud/src/components/document.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
position: relative;
text-overflow: ellipsis;
max-width: 100%;
border-radius: inherit;

&::-webkit-scrollbar {
display: none;
Expand All @@ -18,15 +19,6 @@
position: relative;
}

&-is-deleting {
box-shadow: 0 0 0 1px @palette__red--light-1,
2px 5px 8px fade(@palette__black, 20%);
}

&-is-editing {
box-shadow: 2px 5px 8px fade(@palette__black, 20%);
}

&:hover {
.document-actions-button {
visibility: visible;
Expand Down
1 change: 0 additions & 1 deletion packages/compass-explain-plan/src/components/explain-summary/explain-summary.module.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
@import (reference) 'mongodb-compass/src/app/styles/index.less';

.explain-summary {
background: @palette__white;
padding: 12px;

h3 {
Expand Down
39 changes: 0 additions & 39 deletions packages/compass-schema/src/components/compass-schema/compass-schema.module.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,9 @@

:global {
.schema-field-list {
// .list-group;
.schema-field {
// .list-group-item;
padding: 24px 0 0 0;
margin-bottom: 8px;
background: @palette__white;
transition: all 250ms ease-out;

.row {
margin-bottom: 24px;
Expand Down Expand Up @@ -239,47 +235,12 @@
background: @palette__white;
border: 1px solid @palette__gray--light-1;
}

// .schema-field-type-null {
// background: @series-bg-1;
// }
// .schema-field-type-number {
// background: @series-bg-2;
// }
// .schema-field-type-long {
// background: @series-bg-3;
// }
// .schema-field-type-string {
// background: @series-bg-4;
// }
// .schema-field-type-boolean {
// background: @series-bg-5;
// }
// .schema-field-type-undefined {
// background: @series-bg-6;
// }
// .schema-field-type-date {
// background: @series-bg-7;
// }
// .schema-field-type-objectid {
// background: @series-bg-8;
// }
// .schema-field-type-array {
// background: @series-bg-1;
// }
// .schema-field-type-object {
// background: @series-bg-1;
// }
}
}

:global {
.schema-value-list {
// TODO .small;
// TODO .list-unstyled;

.schema-value-list-item {
// TODO .badge;
display: inline-block;
margin-left: 5px;
margin-right: 5px;
Expand Down