Skip to content

chore(global-writes): fix subtab container styles #6459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024
Merged

chore(global-writes): fix subtab container styles #6459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 22 additions & 25 deletions packages/compass-global-writes/src/components/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,23 +18,20 @@ import ShardingError from './states/sharding-error';
import IncompleteShardingSetup from './states/incomplete-sharding-setup';

const containerStyles = css({
paddingLeft: spacing[400],
paddingRight: spacing[400],
display: 'flex',
width: '100%',
height: '100%',
maxWidth: '700px',
});

const workspaceContentStyles = css({
paddingTop: spacing[400],
paddingLeft: spacing[400],
paddingRight: spacing[400],
maxWidth: '700px',
});

const centeredContent = css({
const loaderStyles = css({
display: 'flex',
alignItems: 'flex-start',
justifyContent: 'center',
alignItems: 'center',
height: '100%',
width: '100%',
marginTop: spacing[1800] * 2,
});

type GlobalWritesProps = {
Expand All @@ -44,16 +41,8 @@ type GlobalWritesProps = {
function ShardingStateView({
shardingStatus,
}: {
shardingStatus: ShardingStatus;
shardingStatus: Exclude<ShardingStatus, 'NOT_READY'>;
}) {
if (shardingStatus === ShardingStatuses.NOT_READY) {
return (
<div className={centeredContent}>
<SpinLoaderWithLabel progressText="Loading …" />
</div>
);
}

if (
shardingStatus === ShardingStatuses.UNSHARDED ||
shardingStatus === ShardingStatuses.SUBMITTING_FOR_SHARDING
Expand Down Expand Up @@ -105,14 +94,22 @@ function ShardingStateView({
}

export function GlobalWrites({ shardingStatus }: GlobalWritesProps) {
if (shardingStatus === ShardingStatuses.NOT_READY) {
return (
<div className={loaderStyles}>
<SpinLoaderWithLabel progressText="Loading …" />
</div>
);
}

return (
<div className={containerStyles}>
<WorkspaceContainer className={workspaceContentStyles}>
<ConfirmationModalArea>
<WorkspaceContainer>
<ConfirmationModalArea>
<div className={containerStyles}>
<ShardingStateView shardingStatus={shardingStatus} />
</ConfirmationModalArea>
</WorkspaceContainer>
</div>
</div>
</ConfirmationModalArea>
</WorkspaceContainer>
);
}
export default connect((state: RootState) => ({
Expand Down
Loading