Skip to content

fix(e2e): actually test the packaged app when running npm run test-packaged #6558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2024
Merged

fix(e2e): actually test the packaged app when running npm run test-packaged #6558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
726eda0
too many dashes
lerouxb Dec 10, 2024
c269d98
OH it works for test-ci, just not test
lerouxb Dec 10, 2024
19f5f70
Merge branch 'main' into actually-test-packaged-app
lerouxb Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/compass-e2e-tests/helpers/test-runner-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,8 @@ if ('then' in parsedArgs && typeof parsedArgs.then === 'function') {
export const context = parsedArgs as CommonParsedArgs &
Partial<DesktopParsedArgs & WebParsedArgs>;

debug('context:', context);
Copy link
Contributor Author

@lerouxb lerouxb Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handy for seeing if it actually picked up all the command-line args it should have.

Copy link
Member

@Anemy Anemy Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-12-10 at 12 23 46 PM

Nice add

Copy link
Collaborator

@gribnoysup gribnoysup Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's printed already a few lines down with secrets removed from the list:

const contextForPrinting = Object.fromEntries(
  Object.entries(context).map(([k, v]) => {
    return [k, /password/i.test(k) ? '<secret>' : v];
  })
);
debug('Running tests with the following arguments:', contextForPrinting);

Is this print doing something different?

Copy link
Contributor Author

@lerouxb lerouxb Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry didn't see it. We can remove it again.

Copy link
Contributor Author

@lerouxb lerouxb Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged it #6561


export function isTestingDesktop(ctx = context): ctx is DesktopParsedArgs {
return testEnv === 'desktop';
}
Expand Down
2 changes: 1 addition & 1 deletion packages/compass-e2e-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"test": "xvfb-maybe --auto-servernum --server-args=\"-screen 0 1432x840x24\" -- ts-node index.ts",
"test-ci": "npm run test",
"posttest-ci": "npm run coverage-report",
"test-packaged": "npm run test -- -- --test-packaged-app",
"test-packaged": "npm run test -- --test-packaged-app",
"test-packaged-ci": "npm run test-ci -- -- --test-packaged-app",
"reformat": "npm run eslint . -- --fix && npm run prettier -- --write .",
"start-server-1": "mongodb-runner start --id=e2e-1 --topology=replset --secondaries=0 -- --port 27091",
Expand Down
Loading