Skip to content

INTMDB-171: [Atlas Go Client] Release a new version #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 27, 2021
Merged

INTMDB-171: [Atlas Go Client] Release a new version #176

merged 3 commits into from
Jan 27, 2021

Conversation

@gssbzn
Copy link
Contributor

@gssbzn gssbzn commented Jan 26, 2021

Description

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@gssbzn gssbzn requested a review from themantissa January 26, 2021 16:35
themantissa
themantissa previously approved these changes Jan 26, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@gssbzn
Copy link
Contributor Author

gssbzn commented Jan 27, 2021

Holding on this seems we have a couple of PRs we should include in the release #177 and #178

@themantissa
Copy link
Collaborator

themantissa commented Jan 27, 2021

@gssbzn both PRs are merged so we should be good to go. Thanks!

@gssbzn gssbzn requested a review from themantissa January 27, 2021 16:02
themantissa
themantissa approved these changes Jan 27, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you :)

@gssbzn gssbzn merged commit b507e8b into master Jan 27, 2021
@gssbzn gssbzn deleted the INTMDB-171 branch January 27, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@themantissa themantissa themantissa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gssbzn @themantissa