Skip to content

INTMDB-158: changed field type to another object #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2021
Merged

INTMDB-158: changed field type to another object #177

merged 1 commit into from
Jan 27, 2021

Conversation

@coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Jan 27, 2021

Description

Moved the parameter type to correct object.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@coderGo93 coderGo93 self-assigned this Jan 27, 2021
gssbzn
gssbzn approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops thanks for fixing this, LGTM

@gssbzn gssbzn mentioned this pull request Jan 27, 2021
Merged
8 tasks
themantissa
themantissa approved these changes Jan 27, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@themantissa
Copy link
Collaborator

themantissa commented Jan 27, 2021

@leofigy if good for you we can merge!

leofigy
leofigy approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@leofigy leofigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themantissa themantissa merged commit 943e1c8 into master Jan 27, 2021
@gssbzn gssbzn deleted the INTMDB-158 branch January 27, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@themantissa themantissa themantissa approved these changes

+2 more reviewers

@gssbzn gssbzn gssbzn approved these changes

@leofigy leofigy leofigy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@coderGo93 coderGo93

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@coderGo93 @themantissa @gssbzn @leofigy