CLOUDP-93381: Add Programmatic Invite Management for organization to the atlas go client #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

andreaangiolillo merged 8 commits into master from CLOUDP-93381

Jun 28, 2021

Collaborator

andreaangiolillo commented Jun 28, 2021 •

edited

Loading

Description

Add Programmatic Invite Management for organization to the atlas go client

Type of change:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Required Checklist:

I have signed the MongoDB CLA
I have added tests that prove my fix is effective or that my feature works
I have added any necessary documentation (if appropriate)
I have run make fmt and formatted my code

Further comments

andreaangiolillo added 5 commits

June 28, 2021 14:10


          CLOUDP-93381: Add Programmatic Invite Management for organization to …

fcf1134

…the atlas go client


          make fmt

7e58515


          Update organizations.go

3989fe4


          Update organizations.go

9378fe9


          Update organizations.go

aed6023

andreaangiolillo commented

View reviewed changes

mongodbatlas/organizations.go Outdated Show resolved Hide resolved

andreaangiolillo marked this pull request as ready for review

June 28, 2021 12:35

andreaangiolillo requested a review from a team as a code owner

June 28, 2021 12:35

andreaangiolillo requested review from a team, gssbzn and threebee and removed request for a team

June 28, 2021 12:35

threebee reviewed

View reviewed changes

mongodbatlas/organizations.go Outdated Show resolved Hide resolved

gssbzn reviewed

View reviewed changes

mongodbatlas/organizations.go Outdated Show resolved Hide resolved

threebee reviewed

View reviewed changes

threebee left a comment

Looking good, I have added a minor nit.

gssbzn reviewed

View reviewed changes

mongodbatlas/organizations.go Outdated Show resolved Hide resolved

gssbzn reviewed

View reviewed changes

mongodbatlas/organizations.go Outdated Show resolved Hide resolved

gssbzn reviewed

View reviewed changes

mongodbatlas/organizations.go Outdated Show resolved Hide resolved

gssbzn reviewed

View reviewed changes

mongodbatlas/organizations.go Outdated Show resolved Hide resolved

gssbzn reviewed

View reviewed changes

mongodbatlas/organizations.go Outdated Show resolved Hide resolved

gssbzn reviewed

View reviewed changes

Contributor

gssbzn left a comment

Good start, left a couple of recommendations to try to align more with the docs

andreaangiolillo added 3 commits

June 28, 2021 15:34


          Addressed PR comments

81b1ada


          renamed files

7ac6fb5


          Refactoring

f3fc6a1

andreaangiolillo requested review from gssbzn and threebee

June 28, 2021 13:42

andreaangiolillo mentioned this pull request

CLOUDP-93382: Add Programmatic Invite Management for project to the atlas go client #228

Merged

8 tasks

gssbzn approved these changes

View reviewed changes

Contributor

gssbzn left a comment

LGTM FYI @themantissa

andreaangiolillo requested a review from themantissa

June 28, 2021 15:49

themantissa approved these changes

View reviewed changes

Collaborator

themantissa left a comment

LGTM, thank you!

andreaangiolillo merged commit 05ebd06 into master

andreaangiolillo mentioned this pull request

CLOUDP-93389: Deletes one unaccepted invitation to the specified Atlas organization. mongodb/mongodb-atlas-cli#724

Merged

5 tasks

gssbzn deleted the CLOUDP-93381 branch

September 14, 2021 12:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet