Skip to content

CLOUDP-93382: Add Programmatic Invite Management for project to the atlas go client #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 29, 2021
Merged

CLOUDP-93382: Add Programmatic Invite Management for project to the atlas go client #228

merged 14 commits into from
Jun 29, 2021
+481 −0

Conversation

@andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jun 28, 2021

Description

Add Programmatic Invite Management for project to the atlas go client

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo
Copy link
Collaborator Author

andreaangiolillo commented Jun 28, 2021

waiting for #227

@andreaangiolillo andreaangiolillo added the WIP work in progress label Jun 28, 2021
@andreaangiolillo andreaangiolillo marked this pull request as ready for review June 28, 2021 17:57
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner June 28, 2021 17:57
@andreaangiolillo andreaangiolillo requested review from threebee and removed request for a team and threebee June 28, 2021 17:57
gssbzn
gssbzn reviewed Jun 28, 2021
View reviewed changes
mongodbatlas/project_invitations.go Outdated

// Invitations gets all unaccepted invitations to the specified Atlas project.
//
// See more: https://docs-atlas-staging.mongodb.com/cloud-docs/docsworker-xlarge/DOCSP-14695/reference/api/project-get-invitations/
Copy link
Contributor

@gssbzn gssbzn Jun 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

gssbzn
gssbzn reviewed Jun 28, 2021
View reviewed changes
Copy link
Contributor

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but there are some links to staging docs

@gssbzn gssbzn removed the WIP work in progress label Jun 28, 2021
@andreaangiolillo andreaangiolillo requested a review from gssbzn June 28, 2021 18:05
gssbzn
gssbzn approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM FYI @themantissa

@andreaangiolillo andreaangiolillo merged commit 8369ddd into master Jun 29, 2021
@gssbzn gssbzn deleted the CLOUDP-93382 branch September 14, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@themantissa themantissa Awaiting requested review from themantissa

1 more reviewer

@gssbzn gssbzn gssbzn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreaangiolillo @gssbzn