MONGOCRYPT-917 fix padding calculation for prefix/suffix#1177
Merged
Conversation
Addresses issue ID:2
kevinAlbs
changed the title
kevinAlbs
marked this pull request as ready for review
May 21, 2026 17:46
kevinAlbs
requested review from
connorsmacd and
mdb-ad
and removed request for
connorsmacd
May 21, 2026 17:46
erwee
requested changes
May 22, 2026
erwee
approved these changes
May 22, 2026
rcsanchez97
approved these changes
May 23, 2026
mdb-ad
pushed a commit
to mdb-ad/libmongocrypt
that referenced
this pull request
Jul 15, 2026
Addresses issue ID:2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix padding calculation when generating affixes for
FLE2InsertUpdatePayloadV2.Background & Motivation
Intended to ensure the count of prefix or suffix tokens ("b.p" / "b.u") increase along with the length of encrypted value ("v"). See report in MONGOCRYPT-913 for details.
Testing
Assertions are added to
test_ciphertext_len_steps_fle2_text_searchto count of suffix tokens. This serves as a regression test, and seemed simpler than the test in the report's Appendix B.To additionally verify changes, the QE Text driver spec and prose tests were run locally with the C driver.