CSHARP-4984: Convert retryable writes spec tests to unified test format #1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSHARP-5374: Convert retryable write command construction prose tests to spec tests CSHARP-5428: Skip aggregate $out test in retryable writes spec on serverless
sanych-sun
requested review from
BorisDog and
JamesKovacs
and removed request for
a team and
JamesKovacs
sanych-sun
commented
Dec 17, 2024
| { | ||
| if (testCase.Name.Contains("bulkWrite.json") && testCase.Name.Contains("is never committed")) | ||
| { | ||
| throw new SkipException("This test is skipped because csharp driver has bug with handling connection closing while mixedBulkWrite operation."); |
Member
Author
There was a problem hiding this comment.
I'll carefully review the CRUD spec to see if this special case is cover there and will create new ticket to fix the bug and unskip the test.
papafe
approved these changes
Dec 19, 2024
Contributor
papafe
left a comment
papafe
left a comment
There was a problem hiding this comment.
LGTM!
It's also satisfying to remove things 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes to sync retryable writes spec tests and will close the following tickets:
CSHARP-4984: Convert retryable writes spec tests to unified test format
CSHARP-5374: Convert retryable write command construction prose tests to spec tests
CSHARP-5428: Skip aggregate $out test in retryable writes spec on serverless