CXX-191 add optional extra parameter support to createCollection #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/mongo/client/dbclientinterface.h
Outdated
Contributor
There was a problem hiding this comment.
You should add a comment to the effect that options in 'extra' that shadow options set by parameters have indeterminate effects.
Contributor
Author
There was a problem hiding this comment.
Ok, didn't see this before.
Contributor
Author
|
Ok, updates are up. Let me know if you think it looks ok. |
src/mongo/unittest/dbclient_test.cpp
Outdated
Contributor
Author
There was a problem hiding this comment.
Sure, we generally don't expect runCommand to fail (especially for "collstats") and this isn't testing the runCommand functionality but why not right?
Contributor
|
LGTM. Ship it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I changed the API here by putting the
extraoption argument beforeinfo(the output parameter). I wouldn't be hung up on changing it back so that the options come after the output to keep things the same. Let me know what you think.