v1: data_key_options (CXX-3237, CXX-3238) #1507
Open
+552
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CXX-3237 and CXX-3238 for the
v1::data_key_optionscomponent.Due to
T const&return types in the v_noabi API,v_noabi::options::data_keycannot be refactored in terms ofv1::data_key_options. Therefore, onlyv_noabi <-> v1conversion functions are defined. Aside from the inlining of most member functions (to reduce the v_noabi ABI footprint), the implementation for v_noabi largely remains unchanged.Note:
view_or_value<T>only exposes a view of its managed object;v_noabi -> v1is therefore copy-only.