CXX-404 Inform user that SCRAM needs --ssl #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/mongo/client/dbclient.cpp
Outdated
There was a problem hiding this comment.
Preprocessor statements should start on the first column
|
Yeah, I was thinking about that. Maybe we should just warn if --ssl isn't enabled, and we didn't find a valid mechanism? |
|
How about this. Just adorn the original message to be something like: mechanism + "mechanism support not available (some mechanisms require the )" |
|
Let me try that again: Adorn the original message so it says something like: "BLAH mechanism support not supported (some mechanisms require the driver be compiled with --ssl or --use-sasl-client)" |
spencerjackson
force-pushed
the
CXX-404
branch
from
9711749 to
177fd62
Compare
|
@acmorrow How does this look? |
src/mongo/client/dbclient.cpp
Outdated
There was a problem hiding this comment.
s/mongo-cxx-driver/driver and good to go.
|
LGTM |
spencerjackson
force-pushed
the
CXX-404
branch
from
177fd62 to
dae3e43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.