CXX-588 Cannot use kvp() with a std::string param #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sub_document.append() specializations for std::string and stdx::string_view keyed tuples fail to forward for the various cv and ref qualified variants. To keep up the perfect forwarding, these functions need to take the key type as a template type parameter and SFINAE themselves to disambiguate.
Contributor
|
This LGTM. @hanumantmk PTAL |
Contributor
|
LGTM for me as well |
hanumantmk
added a commit
that referenced
this pull request
May 13, 2015
sub_document.append() specializations for std::string and stdx::string_view keyed tuples fail to forward for the various cv and ref qualified variants. To keep up the perfect forwarding, these functions need to take the key type as a template type parameter and SFINAE themselves to disambiguate. Closes #291, #281 Signed-off-by: Adam Midvidy <amidvidy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sub_document.append() specializations for std::string and
stdx::string_view keyed tuples fail to forward for the various cv and
ref qualified variants. To keep up the perfect forwarding, these
functions need to take the key type as a template type parameter and
SFINAE themselves to disambiguate.
Credit: @hanumantmk, see PR #281